On 08/09/13 10:09, Dong, Eric wrote: > Sorry, I miss the patch you send to me. > > Check in code in patch: 14538, please help to verify.
I don't understand what's going on. SVN r14537 claims that I tested the MdeModulePkg changes that are present *in that commit*. This is the diffstat for SVN r14537, restricted to MdeModulePkg/, and not counting the binary UNI files: Include/Library/CustomizedDisplayLib.h | 356 + Include/Protocol/DisplayProtocol.h | 350 + Include/Protocol/FormBrowserEx2.h | 90 Library/CustomizedDisplayLib/Colors.h | 44 Library/CustomizedDisplayLib/CustomizedDisplayLib.c | 921 ++ Library/CustomizedDisplayLib/CustomizedDisplayLib.inf | 74 Library/CustomizedDisplayLib/CustomizedDisplayLibInternal.c | 914 ++ Library/CustomizedDisplayLib/CustomizedDisplayLibInternal.h | 295 MdeModulePkg.dec | 10 MdeModulePkg.dsc | 2 Universal/DisplayEngineDxe/DisplayEngineDxe.inf | 66 Universal/DisplayEngineDxe/FormDisplay.c | 3255 +++++++++ Universal/DisplayEngineDxe/FormDisplay.h | 589 + Universal/DisplayEngineDxe/InputHandler.c | 1531 ++++ Universal/DisplayEngineDxe/ProcessOptions.c | 1286 +++ Universal/SetupBrowserDxe/Colors.h | 44 Universal/SetupBrowserDxe/Expression.c | 6 Universal/SetupBrowserDxe/Expression.h | 265 Universal/SetupBrowserDxe/IfrParse.c | 65 Universal/SetupBrowserDxe/InputHandler.c | 1418 ---- Universal/SetupBrowserDxe/Presentation.c | 2425 ++++--- Universal/SetupBrowserDxe/Print.c | 272 Universal/SetupBrowserDxe/ProcessOptions.c | 1075 --- Universal/SetupBrowserDxe/Setup.c | 2302 ++++-- Universal/SetupBrowserDxe/Setup.h | 821 +- Universal/SetupBrowserDxe/SetupBrowserDxe.inf | 26 Universal/SetupBrowserDxe/Ui.c | 4027 ------------ Universal/SetupBrowserDxe/Ui.h | 1067 --- 28 files changed, 13504 insertions(+), 10092 deletions(-) I have most certainly not tested this patch. The patch that I tested was called "MdeModulePkg Patch V2.patch", and it was attached to your message http://thread.gmane.org/gmane.comp.bios.tianocore.devel/3430/focus=3513 The patch that I tested, "MdeModulePkg Patch V2.patch", has the following diffstat: Include/Library/CustomizedDisplayLib.h | 356 + Include/Protocol/DisplayProtocol.h | 350 + Include/Protocol/FormBrowserEx2.h | 90 Library/CustomizedDisplayLib/Colors.h | 44 Library/CustomizedDisplayLib/CustomizedDisplayLib.c | 936 +++ Library/CustomizedDisplayLib/CustomizedDisplayLib.inf | 74 Library/CustomizedDisplayLib/CustomizedDisplayLib.uni | 1 Library/CustomizedDisplayLib/CustomizedDisplayLibInternal.c | 937 +++ Library/CustomizedDisplayLib/CustomizedDisplayLibInternal.h | 307 + MdeModulePkg.dec | 10 MdeModulePkg.dsc | 2 Universal/DisplayEngineDxe/DisplayEngineDxe.inf | 70 Universal/DisplayEngineDxe/FormDisplay.c | 3200 ++++++++++++ Universal/DisplayEngineDxe/FormDisplay.h | 580 ++ Universal/DisplayEngineDxe/FormDisplayStr.uni | 1 Universal/DisplayEngineDxe/InputHandler.c | 1531 +++++ Universal/DisplayEngineDxe/Print.c | 54 Universal/DisplayEngineDxe/ProcessOptions.c | 1286 ++++ Universal/SetupBrowserDxe/Expression.c | 6 Universal/SetupBrowserDxe/Expression.h | 265 Universal/SetupBrowserDxe/IfrParse.c | 65 Universal/SetupBrowserDxe/Presentation.c | 2405 +++++---- Universal/SetupBrowserDxe/Setup.c | 2287 +++++--- Universal/SetupBrowserDxe/Setup.h | 814 +-- Universal/SetupBrowserDxe/SetupBrowserDxe.inf | 28 25 files changed, 13530 insertions(+), 2169 deletions(-) In other words, you've put my Tested-by on a patch I had never seen in my life. Please revert SVN r14538 and SVN r14537, explaining in the revert messages that I had nothing to do with these revisions. Then, the right thing to do would be: - please apply "MdeModulePkg Patch V2.patch" and the UNI files *verbatim*, as they were in your message linked above, - please add my Tested-by from <http://thread.gmane.org/gmane.comp.bios.tianocore.devel/3430/focus=3515>, - please apply "OvmfPkg Patch.patch" from the thread starter <http://thread.gmane.org/gmane.comp.bios.tianocore.devel/3430> with the whitespace fixup that I requested in <http://thread.gmane.org/gmane.comp.bios.tianocore.devel/3430/focus=3433>. You agreed to that change and I referred back to it later in <http://thread.gmane.org/gmane.comp.bios.tianocore.devel/3430/focus=3515>. - Then please add my Tested-by and Reviewed-by to the OvmfPkg commit, - then, if you have followup changes, please send them to the list for review / testing, or (obviously) apply them immediately, without my name. Thanks, Laszlo ------------------------------------------------------------------------------ Get 100% visibility into Java/.NET code with AppDynamics Lite! It's a free troubleshooting tool designed for production. Get down to code-level detail for bottlenecks, with <2% overhead. Download for free and get started troubleshooting in minutes. http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
