On 10/28/13 22:27, Jordan Justen wrote: > The 1MB image with full debug and the shell included is too > large to implement flash based non-volatile variable.
Too small maybe? (I assume that nvvars are going to be written back to OVMF.fd, and if the debuginfo and the shell are in there too, there isn't enough room left, from 1MB.) > > After this change, building with -D FD_SIZE_1MB will > force the smaller flash size. > > The default size for RELEASE build remains at 1MB, so using > -b RELEASE on the build command line will result in a > 1MB flash size. For RELEASE builds -D FD_SIZE_2MB can be > used to produce a 2MB flash image. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jordan Justen <jordan.l.jus...@intel.com> > --- > OvmfPkg/OvmfPkgIa32.fdf | 14 ++++++++++++++ > OvmfPkg/OvmfPkgIa32X64.fdf | 14 ++++++++++++++ > OvmfPkg/OvmfPkgX64.fdf | 14 ++++++++++++++ > 3 files changed, 42 insertions(+) > > diff --git a/OvmfPkg/OvmfPkgIa32.fdf b/OvmfPkg/OvmfPkgIa32.fdf > index df4f227..40f0651 100644 > --- a/OvmfPkg/OvmfPkgIa32.fdf > +++ b/OvmfPkg/OvmfPkgIa32.fdf > @@ -14,7 +14,21 @@ > ## > > > ################################################################################ > + > +# > +# Default flash size for DEBUG build is 2MB. For RELEASE it is 1MB. > +# > +# Defining FD_SIZE_1MB or FD_SIZE_2MB on the build command line can > +# override this. > +# > +[Defines] > +!if $(TARGET) == RELEASE > !ifndef $(FD_SIZE_2MB) > +DEFINE FD_SIZE_1MB= > +!endif > +!endif > + > +!ifdef $(FD_SIZE_1MB) > [FD.OVMF] > BaseAddress = 0xFFF00000 > Size = 0x00100000 This hunk is unreadable with the naked eye (I can't track the nesting of the ifs here), but the resultant descriptor file seems OK. The other two files match. Reviewed-by: Laszlo Ersek <ler...@redhat.com> ------------------------------------------------------------------------------ Android is increasing in popularity, but the open development platform that developers love is also attractive to malware creators. Download this white paper to learn more about secure code signing practices that can help keep Android apps secure. http://pubads.g.doubleclick.net/gampad/clk?id=65839951&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
