On 10/28/13 22:27, Jordan Justen wrote:
> @@ -165,17 +169,27 @@ if [ -z "$PLATFORMFILE" ]; then
> PLATFORMFILE=$WORKSPACE/OvmfPkg/OvmfPkg$Processor.dsc
> fi
>
> -ADD_QEMU_HDA=yes
> -for arg in "$@"
> -do
> - case $arg in
> - -hd[a-d]|-fd[ab]|-cdrom)
> - ADD_QEMU_HDA=no
> - break
> +if [[ "$RUN_QEMU" == "yes" ]]; then
> + qemu_version=$($QEMU_COMMAND -version 2>&1 | tail -1 | awk '{print $4}')
> + case $qemu_version in
> + 1.[6-9].*|1.[1-9][0-9].*|2.*.*)
> + ENABLE_FLASH=yes
> ;;
> esac
> +
> + ADD_QEMU_HDA=yes
> + for arg in "$@"
> + do
> + case $arg in
> + -hd[a-d]|-fd[ab]|-cdrom)
> + ADD_QEMU_HDA=no
> + break
> + ;;
> + esac
> done
The "esac" and the "done" don't seem to be correctly indented here.
(Tangentially: for those qemu versions for which ENABLE_FLASH isn't
automatically set, what effect does --enable-flash (and the consequent
"-pflash $QEMU_FIRMWARE_DIR/bios.bin") have? I have no idea how -pflash
works with OVMF under pre-1.6 qemu.)
Reviewed-by: Laszlo Ersek <[email protected]>
Thanks!
Laszlo
------------------------------------------------------------------------------
November Webinars for C, C++, Fortran Developers
Accelerate application performance with scalable programming models. Explore
techniques for threading, error checking, porting, and tuning. Get the most
from the latest Intel processors and coprocessors. See abstracts and register
http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel
