On 01/11/14 17:34, Laszlo Ersek wrote:
> I'm OK with this patch if you address the other stuff you said you
> would, plus I think I had one other comment below, about updating the
> leading comment of DecompressMemFvs():
>
>>>> diff --git a/OvmfPkg/Sec/SecMain.c b/OvmfPkg/Sec/SecMain.c
>>>> index 902ac85..21c2a36 100644
>>>> --- a/OvmfPkg/Sec/SecMain.c
>>>> +++ b/OvmfPkg/Sec/SecMain.c
>>>> @@ -319,8 +319,8 @@ FindFfsFileAndSection (
>>>>
>>>> **/
>>>> EFI_STATUS
>>>> -DecompressGuidedFv (
>>>> - IN OUT EFI_FIRMWARE_VOLUME_HEADER **Fv
>>>> +DecompressMemFvs (
>>>> + IN OUT EFI_FIRMWARE_VOLUME_HEADER **PeiFv
>>>> )
>>>> {
>>>> EFI_STATUS Status;
>>>
>>> The leading comment should be updated perhaps? On output, *PeiFv points
>>> to the decompressed PEI PV (not main FV).
Hm I could be wrong about this one actually -- if the PEI FV *is* the
main FV ("main" meaning "first" or "primary" rather than "containing
everything"), then the preexistent comment remains fine. Alright.
Thanks
Laszlo
------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today.
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel
