comments below (diffing with v4) On 01/12/14 19:56, Jordan Justen wrote: > By splitting the PEI and DXE phases into separate FVs, > we can only reserve the PEI FV for ACPI S3 support. > This should save about 7MB. > > Unfortunately, this all has to happen in a single commit. > > DEC: > * Remove PcdOvmfMemFv(Base|Size) > * Add PcdOvmfPeiMemFv(Base|Size) > * Add PcdOvmfDxeMemFv(Base|Size) > > FDF: > * Add new PEIFV. Move PEI modules here. > * Remove MAINFV > * Add PEIFV and DXEFV into FVMAIN_COMPACT > - They are added as 2 sections of a file, and compressed > together so they should retain good compression > * PcdOvmf(Pei|Dxe)MemFv(Base|Size) are set > > SEC: > * Find both the PEI and DXE FVs after decompression. > - Copy them separately to their memory locations. > > Platform PEI driver: > * Fv.c: Publish both FVs as appropriate > * MemDetect.c: PcdOvmfMemFv(Base|Size) => > PcdOvmfDxeMemFv(Base|Size) > > OVMF.fd before: > > Non-volatile data storage > FVMAIN_COMPACT uncompressed > FV FFS file LZMA compressed
thank you for using the correct term rather than my cop-out "container". I've done some reading-up (Vol3 of PI), and I can understand it much better now. Thanks. (I did look at this before but it's super-easy to forget in about five minutes.) > MAINFV uncompressed > individual PEI modules uncompressed > FV FFS file compressed with PI_NONE > DXEFV uncompressed > individual DXE modules uncompressed > SECFV uncompressed > > OVMF.fd after: > > Non-volatile data storage > FVMAIN_COMPACT uncompressed > FV FFS file LZMA compressed > PEIFV uncompressed > individual PEI modules uncompressed > DXEFV uncompressed > individual DXE modules uncompressed > SECFV uncompressed > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jordan Justen <[email protected]> > --- > > Updated this patch from the series v4: > * Add OVMF.fd before/after to commit message > * Fix FDF comments > * SecMain:DecompressMemFvs: Fix header comment > * SecMain:DecompressMemFvs: Revert parameter name from PeiFv back to Fv > * SecMain:FindPeiCoreImageBase: Revert paramter name from PeiFv [snip] > -# > -# Files to be placed in MAIN FV > -# > -# This firmware volume will have files placed in it uncompressed, > -# and then then entire firmware volume will be compressed in a > -# single compression operation in order to achieve better > -# overall compression. > -# > - Best way to update is to delete! :) > APRIORI PEI { > INF MdeModulePkg/Universal/PCD/Pei/Pcd.inf > } > @@ -218,12 +213,6 @@ INF > IntelFrameworkModulePkg/Universal/StatusCode/Pei/StatusCodePei.inf > INF OvmfPkg/PlatformPei/PlatformPei.inf > INF MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf > > -FILE FV_IMAGE = A4EF5A93-3F1B-4232-A1C4-F0910E6D1D9C { > - SECTION COMPRESS PI_NONE { > - SECTION FV_IMAGE = DXEFV > - } > -} > - > > ################################################################################ > > [FV.DXEFV] > @@ -400,7 +389,14 @@ READ_LOCK_STATUS = TRUE > > FILE FV_IMAGE = 9E21FD93-9C72-4c15-8C4B-E77F1DB2D792 { > SECTION GUIDED EE4E5898-3914-4259-9D6E-DC7BD79403CF PROCESSING_REQUIRED = > TRUE { > - SECTION FV_IMAGE = MAINFV > + # > + # These firmware volumes will have files placed in them uncompressed, > + # and then then both firmware volumes will be compressed in a > + # single compression operation in order to achieve better > + # overall compression. > + # > + SECTION FV_IMAGE = PEIFV > + SECTION FV_IMAGE = DXEFV > } > } Ah, resurrected here, seems fitting. Alas, the "then then" typo survived (I actually didn't notice it before, which is why I didn't mention it explicitly). Do not resubmit though, please fix it at commit time or don't bother even. Reviewed-by: Laszlo Ersek <[email protected]> Thanks! Laszlo ------------------------------------------------------------------------------ CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments & Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
