Thanks Sava and Reza, it makes sense now. Reviewed-by: Feng Tian <feng.t...@intel.com>
-----Original Message----- From: Reza Jelveh [mailto:reza.jel...@tuhh.de] Sent: Thursday, August 14, 2014 02:15 To: Tian, Feng Cc: edk2-devel@lists.sourceforge.net; ag...@suse.de Subject: Re: [edk2] [PATCH 2/2] MdeModulePkg: Check D2H register status in AhciPioTransfer On 13/08/14 01:04, Tian, Feng wrote: > Hi, Reza > > Thanks for your effort, Reza. I made a little coding style enhancement based > on your proposed patch. please help view it. > > PS: I am a little curious on "some Marvel controllers use D2H only instead of > PIO Setup FIS". If it's that case, does it mean current logic will never > break out the loop? Do we need enhance code to handle this? No it won't break out, but the will instead time out. A. Sava explained the issue in his. I'm attaching a patch with the things we talked about, but this results in duplicate code. There is only a little thing i can think of to reduce the duplicate breaks. ------------------------------------------------------------------------------ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
