I resubmitted the patch with the '\n' added. Thanks, --Samer
-----Original Message----- From: Pawell, Randy Sent: Wednesday, November 26, 2014 11:00 AM To: Tian, Feng Cc: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] MdeModulePkg: Source fixes and cleanup for ARMGCC compiles Hi Feng, I think Samer's new debug message will be fine, providing you add the missing '\n'. The Status variable will then become an in-use variable instead of unused, and so you should remove this file MdeModulePkg/Bus/I2c/I2cDxe/I2cHost.c from my submission. Good catch on the conflict. Thanks, -Randy -----Original Message----- From: Tian, Feng [mailto:feng.t...@intel.com] Sent: Tuesday, November 25, 2014 5:11 PM To: Pawell, Randy; edk2-devel@lists.sourceforge.net; olivier.mar...@arm.com Cc: Tian, Feng Subject: RE: [edk2] MdeModulePkg: Source fixes and cleanup for ARMGCC compiles Thanks for your contribution, Randy. Just a minor comment: El-Haj-Mahmoud, Samer proposed a different fix for I2cHost.c. I think his change adding a debug message is more appropriate. Do you agree? (Of cause I would suggest him to add \n link break at the debug message.) @@ -672,6 +673,10 @@ I2cHostContext->I2cEvent, &I2cHostContext->Status ); + + if (EFI_ERROR (Status)) { + DEBUG((DEBUG_ERROR, "%a: error starting I2C operation, %r", + __FUNCTION__, Status)); } Others look good to me. Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -----Original Message----- From: Pawell, Randy [mailto:randy.paw...@hp.com] Sent: Wednesday, November 26, 2014 05:43 To: edk2-devel@lists.sourceforge.net; Tian, Feng; olivier.mar...@arm.com Subject: [edk2] MdeModulePkg: Source fixes and cleanup for ARMGCC compiles Please review the attached MdeModulePkg patch. Thanks, Randy Pawell ____________________________________________________________________________ MdeModulePkg: Source fixes and cleanup for ARMGCC compiles - Fix EFI_IPv4_ADDRESS usages to use a macro or CopyMem() to copy the structure instead of direct assignment, to avoid runtime alignment errors. - Fix a EFI_INPUT_KEY usage in TerminalDxe to use CopyMem() to copy the structure instead of direct assignment, to avoid runtime alignment error. - Delete excess local variables that are initialized but otherwise unused. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Randy Pawell <randy_paw...@hp.com> ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
