I have not see anything controversial and I do not disagree with Feng's comments. These patches (this one and the one on 2014-11-26) look good to me.
Reviewed-By: Olivier Martin <olivier.mar...@arm.com> > -----Original Message----- > From: Pawell, Randy [mailto:randy.paw...@hp.com] > Sent: 25 November 2014 21:43 > To: edk2-devel@lists.sourceforge.net; feng.t...@intel.com; Olivier > Martin > Subject: [edk2] MdeModulePkg: Source fixes and cleanup for ARMGCC > compiles > > Please review the attached MdeModulePkg patch. > > Thanks, > Randy Pawell > _______________________________________________________________________ > _____ > > MdeModulePkg: Source fixes and cleanup for ARMGCC compiles > - Fix EFI_IPv4_ADDRESS usages to use a macro or CopyMem() to copy the > structure instead of direct assignment, to avoid runtime alignment > errors. > - Fix a EFI_INPUT_KEY usage in TerminalDxe to use CopyMem() to copy > the > structure instead of direct assignment, to avoid runtime alignment > error. > - Delete excess local variables that are initialized but otherwise > unused. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Randy Pawell <randy_paw...@hp.com> ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
