On 01/16/15 09:33, Jordan Justen wrote:
> On 2015-01-15 14:30:20, Laszlo Ersek wrote:
>> Your patch changes the initialization such that when this chunk of
>> memory, allocated by PlatformPei, is empty & lacks the headers,
>> EmuVariableFvbRuntimeDxe no longer populates it with just the headers &
>> structure, but actually copies the 4GB-2MB .. 4GB-2MB+56KB range into
>> it. Because, that's where the data you have prepared with your tool is
>> mapped, by -bios.
>>
>> At the first sight it seems reasonable, but EmuVariableFvbRuntimeDxe is
>> deprecated at this point (Jordan, please feel free to chime in). I'd
>> rather not see a driver being patched that I recommend users to stay
>> away from.
> 
> I think the portion of the stack that attempts to save / restore
> variables in the FAT partition should be dropped at this point.

I agree.

> But, we need to leave the portion that handles variable in RAM for the
> ROM case.

Agreed again.

> 
> I think it is fine to initialize the RAM from the ROM area rather than
> via code.

If that's an R-b or A-b for James's patch, I'm fine with it. :)

> As far as I know, the variable store format is not specified in a
> manner than can be relied upon.

I believe we can consider the following Intel whitepaper an
edk2-internal specification:

  A Tour Beyond BIOS
  Implementing UEFI Authenticated Variables in SMM with EDKII
  - Jiewen Yao, Intel Corporation
  - Vincent J. Zimmer, Intel Corporation
  September 2014

Tool developers might say that their tools target edk2-based firmware.
(Of course, with closed source / proprietary derivatives they can never
be sure.)

Thanks
Laszlo

------------------------------------------------------------------------------
New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
GigeNET is offering a free month of service with a new server in Ashburn.
Choose from 2 high performing configs, both with 100TB of bandwidth.
Higher redundancy.Lower latency.Increased capacity.Completely compliant.
http://p.sf.net/sfu/gigenet
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to