I saw your change sent offline for non-existent environment variable handling
(script / non-script) and looks good for its official review as well.
Reviewed-by : Tapan Shah <[email protected]<mailto:[email protected]>>
From: Carsey, Jaben [mailto:[email protected]]
Sent: Friday, January 23, 2015 6:44 PM
To: Shah, Tapan; Peterson, Joe
Cc: [email protected]; Carsey, Jaben
Subject: RE: [PATCH] ShellPkg: refine command line parsing
Yes, for non-script files. It works in scripts already.
From: Shah, Tapan [mailto:[email protected]]
Sent: Friday, January 23, 2015 12:39 PM
To: Carsey, Jaben; Peterson, Joe
Cc: [email protected]<mailto:[email protected]>
Subject: RE: [PATCH] ShellPkg: refine command line parsing
Importance: High
Are you going to post a separate review request to handle non-existent
environment variable in quoted string?
From: Carsey, Jaben [mailto:[email protected]]
Sent: Friday, January 23, 2015 2:30 PM
To: Shah, Tapan; Peterson, Joe
Cc: [email protected]<mailto:[email protected]>;
Carsey, Jaben
Subject: RE: [PATCH] ShellPkg: refine command line parsing
Update. Now does these cases:
echo "hi"
echo "hi hi"
echo "hi
echo "hi^""
echo "^hi"
echo "%uefiversion%%test%"
echo "hi^^"
echo "hi^^^""
echo hi^^
echo hi^^^
echo "testing is "done""
echo "hi^"
echo =L"this is a test"
echo this" is a "test
please re-review.
-Jaben
From: Shah, Tapan [mailto:[email protected]]
Sent: Thursday, January 22, 2015 2:52 PM
To: Carsey, Jaben; Peterson, Joe
Cc: [email protected]<mailto:[email protected]>
Subject: RE: [PATCH] ShellPkg: refine command line parsing
Importance: High
Reviewed-by: Tapan Shah <[email protected]<mailto:[email protected]>>
Update copyright year to 2015 in Shell.c and ShellParametersProtocol.h files.
From: Carsey, Jaben [mailto:[email protected]]
Sent: Thursday, January 22, 2015 3:57 PM
To: Peterson, Joe; Shah, Tapan
Cc: [email protected]<mailto:[email protected]>;
Carsey, Jaben
Subject: [PATCH] ShellPkg: refine command line parsing
Tapan and Joe,
Can you review this?
The following test cases were used for the unit testing:
echo "hi"
echo "hi hi"
echo "hi
echo "hi^""
echo "^hi"
echo "%uefiversion%%test%"
echo "hi^^"
echo "hi^^^""
echo hi^^
echo hi^^^
ShellPkg: refine command line parsing
Correctly divide up parameters for Argc/Argv including quote ("), escape (^),
and space ( ) processing.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey
<[email protected]<mailto:[email protected]>>
------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel
