Reviewed-by: Joe Peterson <joe.peter...@intel.com>


From: Carsey, Jaben
Sent: Friday, January 23, 2015 12:30 PM
To: Shah, Tapan; Peterson, Joe
Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben
Subject: RE: [PATCH] ShellPkg: refine command line parsing

Update.  Now does these cases:

echo "hi"
echo "hi   hi"
echo "hi
echo "hi^""
echo "^hi"
echo "%uefiversion%%test%"
echo "hi^^"
echo "hi^^^""
echo hi^^
echo hi^^^
echo "testing is "done""
echo "hi^"
echo =L"this is a test"
echo this" is a "test

please re-review.

-Jaben

From: Shah, Tapan [mailto:tapands...@hp.com]
Sent: Thursday, January 22, 2015 2:52 PM
To: Carsey, Jaben; Peterson, Joe
Cc: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net>
Subject: RE: [PATCH] ShellPkg: refine command line parsing
Importance: High

Reviewed-by: Tapan Shah <tapands...@hp.com<mailto:tapands...@hp.com>>

Update copyright year to 2015 in Shell.c and ShellParametersProtocol.h files.

From: Carsey, Jaben [mailto:jaben.car...@intel.com]
Sent: Thursday, January 22, 2015 3:57 PM
To: Peterson, Joe; Shah, Tapan
Cc: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net>; 
Carsey, Jaben
Subject: [PATCH] ShellPkg: refine command line parsing

Tapan and Joe,

Can you review this?

The following test cases were used for the unit testing:
echo "hi"
echo "hi   hi"
echo "hi
echo "hi^""
echo "^hi"
echo "%uefiversion%%test%"
echo "hi^^"
echo "hi^^^""
echo hi^^
echo hi^^^

ShellPkg: refine command line parsing

Correctly divide up parameters for Argc/Argv including quote ("), escape (^), 
and space ( ) processing.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey 
<jaben.car...@intel.com<mailto:jaben.car...@intel.com>>
------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to