On 03/05/15 12:38, Leif Lindholm wrote: > On 05/03/15 10:19, Laszlo Ersek wrote: >> Public branch: <https://github.com/lersek/edk2/commits/build_tweaks>. >> >> Note that qemu commit aa685789 [1] mentioned in patches #2 and #4 is >> pending a pull [2]. The commit hash is expected to stay stable [3]. > > Will enabling XHCI cause any issues on earlier qemu versions, or will > they simply fall back to EHCI?
qemu has aa685789 fw has XhciDxe usb-kbd requested with result -------- -------------- ---------------------- ---------------------- * no ich9-usb-ehci1 USB2 keyboard okay * no nec-usb-xhci no keyboard no yes ich9-usb-ehci1 USB2 keyboard okay no yes nec-usb-xhci crash: failed ASSERT() yes yes ich9-usb-ehci1 USB2 keyboard okay yes yes nec-usb-xhci USB3 keyboard okay That is, assuming an earlier qemu version and an updated firmware, if you stick with ich9-usb-ehci1, you'll see no changes (USB2 keyboard will continue to work). Assuming an earlier qemu version and an updated firmware, if you "use" nec-usb-xhci, then the firmware update means going from "no keyboard" to "crash". I quoted the word "use" in the previous sentence because you most probably have not been using nec-usb-xhci, since it has not given you a working keyboard anyway. The firmware update won't break existing working setups. It will crash for users who update their firmware, but not qemu, and try nec-usb-xhci for the first time. (Saying "hey OVMF / AAVMF support XHCI now!".) This should be prevented by the qemu commit reference in the edk2 commit messages. Thanks Laszlo > > / > Leif > >> [1] https://www.kraxel.org/cgit/qemu/commit/?id=aa685789 >> [2] http://lists.nongnu.org/archive/html/qemu-devel/2015-03/msg00394.html >> [3] http://lists.nongnu.org/archive/html/qemu-devel/2015-03/msg00658.html >> >> Thanks >> Laszlo >> >> Laszlo Ersek (4): >> ArmVirtualizationPkg: build UEFI shell from source >> ArmVirtualizationPkg/ArmVirtualizationQemu: include XHCI driver >> MdeModulePkg: XhciDxe: list ARM and AARCH64 as valid architectures >> OvmfPkg: include XHCI driver >> >> MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf | 2 +- >> ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualization.dsc.inc | 26 >> ++++++++++++++++++++ >> ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualizationQemu.dsc | 1 + >> ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualizationQemu.fdf | 3 ++- >> ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualizationXen.fdf | 2 +- >> OvmfPkg/OvmfPkgIa32.dsc | 1 + >> OvmfPkg/OvmfPkgIa32.fdf | 1 + >> OvmfPkg/OvmfPkgIa32X64.dsc | 1 + >> OvmfPkg/OvmfPkgIa32X64.fdf | 1 + >> OvmfPkg/OvmfPkgX64.dsc | 1 + >> OvmfPkg/OvmfPkgX64.fdf | 1 + >> 11 files changed, 37 insertions(+), 3 deletions(-) >> > > > -- IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended > recipient, please notify the sender immediately and do not disclose the > contents to any other person, use it for any purpose, or store or copy > the information in any medium. Thank you. > > ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, > Registered in England & Wales, Company No: 2557590 > ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 > 9NJ, Registered in England & Wales, Company No: 2548782 > ------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
