On 9 May 2015 at 22:39, Andrew Fish <af...@apple.com> wrote:
> Ard,
>
> Would removing the Reserved field and making Size a UINT64 also fix the issue?
>
Yes, but since the Size field is assigned to POOL_TAIL::Size as well,
and used in comparisons in CoreFreePoolI(), I thought this would be
the cleaner approach. But if you prefer that, I am happy to update the
patch.
> Contributed-under: TianoCore Contribution Agreement 1.0
> Reviewed-by: Andrew Fish <af...@apple.com>
>
> Thanks,
>
> Andrew Fish
>
>
>> On May 9, 2015, at 1:15 PM, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote:
>>
>> According to the UEFIv2.5 spec section 6.2, the allocations returned
>> by the AllocatePool () boot service must be 8 byte aligned.
>>
>> So make our implementation conform to the spec, by rearranging the
>> pool head struct so that its size is always a multiple of 8 bytes.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org>
>> ---
>> MdeModulePkg/Core/Dxe/Mem/Pool.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/MdeModulePkg/Core/Dxe/Mem/Pool.c
>> b/MdeModulePkg/Core/Dxe/Mem/Pool.c
>> index ac717fb65f7a..6f8f5cfb295d 100644
>> --- a/MdeModulePkg/Core/Dxe/Mem/Pool.c
>> +++ b/MdeModulePkg/Core/Dxe/Mem/Pool.c
>> @@ -26,9 +26,9 @@ typedef struct {
>> #define POOL_HEAD_SIGNATURE SIGNATURE_32('p','h','d','0')
>> typedef struct {
>> UINT32 Signature;
>> - UINT32 Reserved;
>> EFI_MEMORY_TYPE Type;
>> UINTN Size;
>> + UINTN Reserved;
>> CHAR8 Data[1];
>> } POOL_HEAD;
>>
>> --
>> 1.9.1
>>
>>
>> ------------------------------------------------------------------------------
>> One dashboard for servers and applications across Physical-Virtual-Cloud
>> Widest out-of-the-box monitoring support with 50+ applications
>> Performance metrics, stats and reports that give you Actionable Insights
>> Deep dive visibility with transaction tracing using APM Insight.
>> http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/edk2-devel
>
>
> ------------------------------------------------------------------------------
> One dashboard for servers and applications across Physical-Virtual-Cloud
> Widest out-of-the-box monitoring support with 50+ applications
> Performance metrics, stats and reports that give you Actionable Insights
> Deep dive visibility with transaction tracing using APM Insight.
> http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/edk2-devel
------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
