Thanks. I've attached a new version of the patch.
--
Bruce
On 5/29/2015 2:41 AM, Tian, Feng wrote:
Hi, Bruce
The modules in MdeModulePkg couldn't depend on OptionRomPkg. So your change is
not ok for me.
I would prefer to directly assign 0x00020032 to
gNvmExpressDriverSupportedEfiVersion.FirmwareVersion.
Thanks
Feng
-----Original Message-----
From: Bruce Cran [mailto:br...@cran.org.uk]
Sent: Friday, May 29, 2015 09:18
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [PATCH] Bump default driver supported efi version to 2.5
I noticed that the default value used for the driver supported efi version
protocol was 0x2000a - UEFI 2.1. The attached patch bumps it to
2.5 and updates the NvmExpress driver to use the Pcd from OptionRomPkg.
--
Bruce
From 8552db0077db0629bf9ab1fafdc70e9397501505 Mon Sep 17 00:00:00 2001
From: Bruce Cran <bruce.c...@gmail.com>
Date: Thu, 28 May 2015 19:11:53 -0600
Subject: [PATCH] Bump the default driver supported efi version value to UEFI
2.5
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Bruce Cran <bruce.c...@gmail.com>
---
MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.c | 2 +-
MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf | 2 +-
OptionRomPkg/OptionRomPkg.dec | 2 +-
OptionRomPkg/OptionRomPkg.dsc | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.c
b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.c
index 99f89f1..efa373a 100644
--- a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.c
+++ b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.c
@@ -1059,7 +1059,7 @@ NvmExpressDriverEntry (
// Install EFI Driver Supported EFI Version Protocol required for
// EFI drivers that are on PCI and other plug in cards.
//
- gNvmExpressDriverSupportedEfiVersion.FirmwareVersion = 0x00020028;
+ gNvmExpressDriverSupportedEfiVersion.FirmwareVersion = 0x00020032;
Status = gBS->InstallMultipleProtocolInterfaces (
&ImageHandle,
&gEfiDriverSupportedEfiVersionProtocolGuid,
diff --git a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf
b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf
index f73d6af..23e7473 100644
--- a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf
+++ b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf
@@ -75,4 +75,4 @@
#
[UserExtensions.TianoCore."ExtraFiles"]
- NvmExpressDxeExtra.uni
\ No newline at end of file
+ NvmExpressDxeExtra.uni
diff --git a/OptionRomPkg/OptionRomPkg.dec b/OptionRomPkg/OptionRomPkg.dec
index ea4d57b..de3af87 100644
--- a/OptionRomPkg/OptionRomPkg.dec
+++ b/OptionRomPkg/OptionRomPkg.dec
@@ -43,5 +43,5 @@
gOptionRomPkgTokenSpaceGuid.PcdSupportUga|TRUE|BOOLEAN|0x00010005
[PcdsFixedAtBuild, PcdsPatchableInModule]
-
gOptionRomPkgTokenSpaceGuid.PcdDriverSupportedEfiVersion|0x0002000a|UINT32|0x00010003
+
gOptionRomPkgTokenSpaceGuid.PcdDriverSupportedEfiVersion|0x00020032|UINT32|0x00010003
diff --git a/OptionRomPkg/OptionRomPkg.dsc b/OptionRomPkg/OptionRomPkg.dsc
index 03592f8..860568e 100644
--- a/OptionRomPkg/OptionRomPkg.dsc
+++ b/OptionRomPkg/OptionRomPkg.dsc
@@ -76,7 +76,7 @@
gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|0x0
gEfiMdePkgTokenSpaceGuid.PcdMaximumAsciiStringLength|0x0
gEfiMdePkgTokenSpaceGuid.PcdMaximumLinkedListLength|0x0
- gOptionRomPkgTokenSpaceGuid.PcdDriverSupportedEfiVersion|0x0002000a #
EFI_2_10_SYSTEM_TABLE_REVISION
+ gOptionRomPkgTokenSpaceGuid.PcdDriverSupportedEfiVersion|0x00020032 #
EFI_2_50_SYSTEM_TABLE_REVISION
###################################################################################################
#
--
2.4.1
------------------------------------------------------------------------------
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
