Hi, Bruce I found we should use EFI_SPECIFICATION_VERSION macro here rather than hardcode it to a 0x000200xx value. Do you agree?
Thanks Feng -----Original Message----- From: Tian, Feng Sent: Monday, June 01, 2015 10:58 To: Bruce Cran; [email protected] Cc: Tian, Feng Subject: RE: [edk2] [PATCH] Bump default driver supported efi version to 2.5 Could you split it to 2 patches? One is specific for MdeModulePkg and another is for OpromPkg. Then different package owners could review your changes individually. MdeModulePkg change is good: Reviewed-by: Feng Tian <[email protected]> I will help check in the MdeModulePkg part. Thanks Feng -----Original Message----- From: Bruce Cran [mailto:[email protected]] Sent: Friday, May 29, 2015 23:26 To: Tian, Feng; [email protected] Subject: Re: [edk2] [PATCH] Bump default driver supported efi version to 2.5 Thanks. I've attached a new version of the patch. -- Bruce On 5/29/2015 2:41 AM, Tian, Feng wrote: > Hi, Bruce > > The modules in MdeModulePkg couldn't depend on OptionRomPkg. So your change > is not ok for me. > > I would prefer to directly assign 0x00020032 to > gNvmExpressDriverSupportedEfiVersion.FirmwareVersion. > > Thanks > Feng > > -----Original Message----- > From: Bruce Cran [mailto:[email protected]] > Sent: Friday, May 29, 2015 09:18 > To: [email protected] > Subject: [edk2] [PATCH] Bump default driver supported efi version to 2.5 > > I noticed that the default value used for the driver supported efi version > protocol was 0x2000a - UEFI 2.1. The attached patch bumps it to > 2.5 and updates the NvmExpress driver to use the Pcd from OptionRomPkg. > > -- > Bruce ------------------------------------------------------------------------------ Monitor 25 network devices or servers for free with OpManager! OpManager is web-based network management software that monitors network devices and physical & virtual servers, alerts via email & sms for fault. Monitor 25 devices for free with no restriction. Download now http://ad.doubleclick.net/ddm/clk/292181274;119417398;o _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
