On 2015-07-01 17:41:11, Gao, Liming wrote: > Jordan: > Agree. We will follow this rule, apply the patch and push it > without any modification.
My point is that if there is a mistake, we should not bother to update the log message to fix that mistake. Hopefully we can just be more careful with the patch message if we stop thinking that we can go back and fix it later. :) > gcc-4k is added for new UEFI2.5 Properties Table. When enable this > feature, gcc-4k script will be required for RUNTIME driver. It can > be configured in [BuildOptions] of DSC file for RUNTIME driver > only. We could update Ovmf to enable this feature, which can be > turned on/off by build flag. Is it OK to you? Is there an example of how to enable it for a platform? Or, the feature is still is not fully complete? -Jordan > -----Original Message----- > From: Justen, Jordan L > Sent: Thursday, July 2, 2015 6:42 AM > To: Liu, Yingke D; Ard Biesheuvel > Cc: edk2-devel@lists.sourceforge.net; Gao, Liming > Subject: RE: [PATCH] BaseTools: fix a syntax error in 4 KB aligned GNU ld > linker script > > On 2015-07-01 01:34:56, Liu, Yingke D wrote: > > Hi Ard, > > > > Thanks for the comments, I have updated the log message. > > For future reference, I think you should not bother to update the > log message. It is a bad practice, and the git archive will not see > the updated log message anyhow. It should also be noted that it will > not be possible to update the commit message when git is the main > upstream repo. > > I think it is best just to acknowledge the mistake, and remember it > for next time. > > I have a question. Where is the 4K script used? git grep gcc-4K > shows no references to it. > > -Jordan > > > -----Original Message----- > > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > > Sent: Wednesday, July 01, 2015 16:12 > > To: Liu, Yingke D > > Cc: edk2-devel@lists.sourceforge.net; Justen, Jordan L; Gao, Liming > > Subject: Re: [PATCH] BaseTools: fix a syntax error in 4 KB aligned GNU > > ld linker script > > > > On 30 June 2015 at 13:02, Gao, Liming <liming....@intel.com> wrote: > > > Reviewed-by: Liming Gao <liming....@intel.com> > > > > > > > Hello Dennis, > > > > Thanks for merging this. > > > > Next time, could you please keep the subject line as well? > > > > > Subject: [PATCH] BaseTools: fix a syntax error in 4 KB aligned GNU > > > ld linker script > > > > You have used this instead: > > > > > There needs to be a space between the output section name and the > > > colon, i.e., > > > > as the subject line which looks a little silly imo > > > > Thanks, > > Ard. > > > > > > > -----Original Message----- > > > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > > > Sent: Tuesday, June 30, 2015 7:00 PM > > > To: Liu, Yingke D; Gao, Liming; edk2-devel@lists.sourceforge.net > > > Cc: Ard Biesheuvel > > > Subject: [PATCH] BaseTools: fix a syntax error in 4 KB aligned GNU > > > ld linker script > > > > > > There needs to be a space between the output section name and the > > > colon, i.e., > > > > > > .text : ALIGN(0x1000) > > > ^ > > > > > > Fix this for all output sections > > > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > > Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> > > > --- > > > BaseTools/Scripts/gcc-4K-align-ld-script | 10 +++++----- > > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > > > diff --git a/BaseTools/Scripts/gcc-4K-align-ld-script > > > b/BaseTools/Scripts/gcc-4K-align-ld-script > > > index 1f23079023a6..16cf623a3362 100644 > > > --- a/BaseTools/Scripts/gcc-4K-align-ld-script > > > +++ b/BaseTools/Scripts/gcc-4K-align-ld-script > > > @@ -3,12 +3,12 @@ SECTIONS > > > { > > > /* . = 0 + SIZEOF_HEADERS; */ > > > . = 0x280; > > > - .text: ALIGN(0x1000) > > > + .text : ALIGN(0x1000) > > > { > > > *(.text .stub .text.* .gnu.linkonce.t.*) > > > . = ALIGN(0x20); > > > } > > > - .data: ALIGN(0x1000) > > > + .data : ALIGN(0x1000) > > > { > > > *( > > > .rodata .rodata.* .gnu.linkonce.r.* @@ -18,16 +18,16 @@ SECTIONS > > > ) > > > . = ALIGN(0x20); > > > } > > > - .eh_frame: ALIGN(0x1000) > > > + .eh_frame : ALIGN(0x1000) > > > { > > > KEEP (*(.eh_frame)) > > > } > > > - .got: ALIGN(0x1000) > > > + .got : ALIGN(0x1000) > > > { > > > *(.got .got.*) > > > . = ALIGN(0x20); > > > } > > > - .rela: ALIGN(0x1000) > > > + .rela : ALIGN(0x1000) > > > { > > > *(.rela .rela.*) > > > } > > > -- > > > 1.9.1 > > > ------------------------------------------------------------------------------ Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
