Hi Qui, On Tue, Jul 07, 2015 at 04:41:35PM +0800, Qiu Shumin wrote: > > Qiu Shumin (2): > SecurityPkg: Refine the function comments. > CryptoPkg: Refine the function comments. > > CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyNull.c | 2 +- > .../BaseCryptLibRuntimeCryptProtocol/Pk/CryptPkcs7VerifyNull.c | 2 +- > SecurityPkg/Pkcs7Verify/Pkcs7VerifyDxe/Pkcs7VerifyDxe.c | 6 > ------ > 3 files changed, 2 insertions(+), 8 deletions(-) > > -- > 1.9.5.msysgit.1
Neither this cover letter or the patches themselves explain what these changes do. For 1/2, documentation of some parameters (that are not present in the function prototype) is removed. This does not require a huge lot of documentation, but something like "Delete description of non-existent parameters Content and ContentSize from P7CheckTrust() description." would be useful to have. For 2/2, /* */ is changed to /** **/, presumably as a command to doxygen? If so, this would be useful to state in the commit message for that patch. Best Regards, Leif ------------------------------------------------------------------------------ Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
