Regarding the commit message, how about: ===
SecurityPkg/Pkcs7VerifyDxe: Cleanup P7CheckTrust function comments The comments for P7CheckTrust described Content and ContentSize parameters, but they don't exist. === With the updated commit message: Reviewed-by: Jordan Justen <jordan.l.jus...@intel.com> On 2015-07-07 01:41:36, Qiu Shumin wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Qiu Shumin <shumin....@intel.com> > CC: Long, Qin <qin.l...@intel.com> Did this Cc work with git send-email? I always worry when the comma (,) is used in the name. Usually it is written as: Cc: Qin Long <qin.l...@intel.com> But, it might also work if you add quotes around the name: Cc: "Long, Qin" <qin.l...@intel.com> -Jordan > --- > SecurityPkg/Pkcs7Verify/Pkcs7VerifyDxe/Pkcs7VerifyDxe.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/SecurityPkg/Pkcs7Verify/Pkcs7VerifyDxe/Pkcs7VerifyDxe.c > b/SecurityPkg/Pkcs7Verify/Pkcs7VerifyDxe/Pkcs7VerifyDxe.c > index 6319255..13c9138 100644 > --- a/SecurityPkg/Pkcs7Verify/Pkcs7VerifyDxe/Pkcs7VerifyDxe.c > +++ b/SecurityPkg/Pkcs7Verify/Pkcs7VerifyDxe/Pkcs7VerifyDxe.c > @@ -619,12 +619,6 @@ _Exit: > @param[in] AllowedDb Pointer to a list of pointers to > EFI_SIGNATURE_LIST > structures which contains lists of X.509 > certificates > of approved signers. > - @param[out] Content An optional caller-allocated buffer into which > the > - function will copy the content of PKCS7 > signedData. > - @param[in,out] ContentSize On input, points of the size in bytes of the > optional > - buffer Content previously allocated by caller. > On output, > - the value will contain the actual size of the > content > - extracted from the signedData. > > @retval EFI_SUCCESS The PKCS7 signedData is trusted. > @retval EFI_SECURITY_VIOLATION Fail to verify the signature in PKCS7 > signedData. > -- > 1.9.5.msysgit.1 > > > ------------------------------------------------------------------------------ > Don't Limit Your Business. Reach for the Cloud. > GigeNET's Cloud Solutions provide you with the tools and support that > you need to offload your IT needs and focus on growing your business. > Configured For All Businesses. Start Your Cloud Today. > https://www.gigenetcloud.com/ > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
