We don't use the coupons, but as you describe it, it seems it may have an easy solution. I encourage you to try a PR on GitHub .
El jueves, 18 de enero de 2018, 13:55:25 (UTC+1), Ibo Sy escribió: > > Thank you, I will consider this. > > The issue I found affects Coupon codes. If you apply a coupon code with an > expiration date (which is a bit of an added feature anyway, as you can only > set them through the sales_admin dashboard), the expiration date is only > checked when added to the cart, but not on checkout. As the cart is saved, > a user can apply a coupon code today which expires tomorrow, and finish the > checkout a week later. A validation for all applied coupons on the > processor can fix this. > > On Friday, January 12, 2018 at 1:31:56 PM UTC+1, [email protected] wrote: >> >> We are still using the ShoppingCart as well in production. Last year a >> simple PR on this module was accepted. We will keep using it as long as it >> is available. When it disappears, we will have to change to e-commerce. >> We've tried it out in Ficus, but haven't properly configured, that's why we >> keep using the ShoppingCart module. >> >> If you know the solution for the issue, maybe you can try a Pull Request >> on GitHub. Maybe the Open edX team will consider your PR. >> >> What is the issue about if I may ask? >> >> >> El viernes, 5 de enero de 2018, 19:38:28 (UTC+1), Ibo Sy escribió: >>> >>> Hey, I found an issue in the shoppingcart module and was wondering, is >>> this still being maintained despite the e-commerce module? If yes, should >>> the issue be reported through JIRA as CRI? Is anyone even still using this >>> module? >>> >>> Cheers, >>> Ibo >>> >> -- You received this message because you are subscribed to the Google Groups "General Open edX discussion" group. To view this discussion on the web visit https://groups.google.com/d/msgid/edx-code/57306497-39cd-49a6-9a03-5b706c70c044%40googlegroups.com.
