On 17.12.18 17:06, Mathieu Alexandre-Tétreault wrote:
Signed-off-by: Mathieu Tetreault <[email protected]> --- drivers/watchdog/itco.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/watchdog/itco.c b/drivers/watchdog/itco.c index b7b6e80..5a21a06 100644 --- a/drivers/watchdog/itco.c +++ b/drivers/watchdog/itco.c @@ -95,7 +95,7 @@ init(EFI_PCI_IO *pci_io, UINT16 pci_vendor_id, UINT16 pci_device_id, return status; } value &= 0xfc00; - value |= ((timeout * 10) / 6) & 0x3ff; + value |= timeout & 0x3ff; status = uefi_call_wrapper(pci_io->Io.Write, 6, pci_io, EfiPciIoWidthUint16, EFI_PCI_IO_PASS_THROUGH_BAR,
Interesting - so we were waiting too long so far? Or my reference back then, QEMU, is not emulating this accurately. I suppose you tested this against a real v3 iTCO implementation, right?
Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux -- You received this message because you are subscribed to the Google Groups "EFI Boot Guard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/efibootguard-dev/0938349f-2756-2232-80bc-c9e2b599fc36%40siemens.com. For more options, visit https://groups.google.com/d/optout.
