On 12/20/18 11:40 AM, Jan Kiszka wrote: > On 17.12.18 17:06, Mathieu Alexandre-Tétreault wrote: >> Signed-off-by: Mathieu Tetreault <[email protected]> >> --- >> drivers/watchdog/itco.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/watchdog/itco.c b/drivers/watchdog/itco.c >> index b7b6e80..5a21a06 100644 >> --- a/drivers/watchdog/itco.c >> +++ b/drivers/watchdog/itco.c >> @@ -95,7 +95,7 @@ init(EFI_PCI_IO *pci_io, UINT16 pci_vendor_id, UINT16 >> pci_device_id, >> return status; >> } >> value &= 0xfc00; >> - value |= ((timeout * 10) / 6) & 0x3ff; >> + value |= timeout & 0x3ff; >> status = uefi_call_wrapper(pci_io->Io.Write, 6, pci_io, >> EfiPciIoWidthUint16, >> EFI_PCI_IO_PASS_THROUGH_BAR, >> > Interesting - so we were waiting too long so far? Or my reference back then, > QEMU, is not emulating this accurately. I suppose you tested this against a > real > v3 iTCO implementation, right? > > Jan > I indeed tested with a real iTCO v3 device ( baytrail to be exact). I timed the watchdog using a stop watch. The timer was started as soon as ebg was displaying the wdog message. We timed 60sec +/- 3 seconds which I assume was due to a lack of synchronism between the start of the wdt and the start of my stop watch.
Mathieu -- You received this message because you are subscribed to the Google Groups "EFI Boot Guard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/efibootguard-dev/CY4PR11MB1685E79EA9FE308B0B21187BB2BF0%40CY4PR11MB1685.namprd11.prod.outlook.com. For more options, visit https://groups.google.com/d/optout.
