> In fact I believe Elf->maximum_size should be off64_t and not size_t as this > way 32bit hosts cannot handle >2GB ELF files, can they?
Yes, I guess it should change. In most places maximum_size is only used for the size that's mapped in, which by definition must fit in size_t. But there are a few places like this one where it's used for the size of the file when not mapped too. So it looks like it should be able to hold anything st_size could be. > But as 32bit hosts are dead I did not try to do the more invasive change. :-) They are not dead enough to ignore this kind of problem yet. > OK to merge to master? It is now in <jankratochvil/pending>. Yes, that looks fine. Someone should do the more extensive change, including an audit of all the uses of maximum_size. Would you like to do it? Thanks, Roland _______________________________________________ elfutils-devel mailing list [email protected] https://fedorahosted.org/mailman/listinfo/elfutils-devel
