Actually, please don't go ahead. Since Access.pop/2 calls module.pop/2, adding a default would change the callbacks and, therefore, the current API. I would probably wait until there is a strong need for such feature.
On Wed, Apr 7, 2021 at 10:02 AM José Valim <[email protected]> wrote: > Yes, please go ahead. > > On Wed, Apr 7, 2021 at 7:41 AM Felipe Stival <[email protected]> wrote: > >> We have Map.pop/2,3, Keyword.pop/2,3, so I think that, for coherency, we >> should also have default return support on Access.pop. >> >> This would require no additional callbacks, just a minor addition in the >> Access.pop implementation. >> >> I can send a PR if you agree. >> >> -- >> You received this message because you are subscribed to the Google Groups >> "elixir-lang-core" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/elixir-lang-core/dd8328f8-f53a-4c96-a831-66dc1438bc15n%40googlegroups.com >> <https://groups.google.com/d/msgid/elixir-lang-core/dd8328f8-f53a-4c96-a831-66dc1438bc15n%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> > -- You received this message because you are subscribed to the Google Groups "elixir-lang-core" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/CAGnRm4Lpyhya1FZafkZiRxCHXq_zBX7kb3ctfbz3LSRqfd%3Dang%40mail.gmail.com.
