Hello, Dmitri Makarov <dmaka...@alumni.stanford.edu> writes:
> If you haven't pushed the patch yet, here is attached an updated > patch, with a correction in the commit message, and a minor correction > in one of the comments. Thank you. Some comments follow. > > On Thu, Sep 10, 2015 at 11:28 AM, Alan Schmitt > > <alan.schm...@polytechnique.org> wrote: >> LGTM (with a tiny caveat that I can fix: the first line of the commit >> message should not end with a dot). Nicolas, can I push this? Sure. However, it would be nice to fix the two minor issues below. > From: Dmitri Makarov <dmaka...@alumni.stanford.edu> > Date: Wed, 9 Sep 2015 17:24:42 +0200 > Subject: [PATCH] org-mac-link.el: Handle links to/from Adobe Acrobat > > * contrib/lisp/org-mac-link.el: Add new link type "acrobat" to grab > links to documents open in Adobe Acrobat application. You need to mention new functions and variables in the commit message. > +(defun as-get-acrobat-page-link () Wrong namespace. It should be prefixed with "org-mac-". Regards, -- Nicolas Goaziou
