Attached is the patch with requested corrections. I hope now this
small patch is sufficiently well commented.
Regards,
Dmitri
On Thu, Sep 10, 2015 at 11:57 AM, Nicolas Goaziou
<m...@nicolasgoaziou.fr> wrote:
> Hello,
>
> Dmitri Makarov <dmaka...@alumni.stanford.edu> writes:
>
>> If you haven't pushed the patch yet, here is attached an updated
>> patch, with a correction in the commit message, and a minor correction
>> in one of the comments.
>
> Thank you. Some comments follow.
>
>> > On Thu, Sep 10, 2015 at 11:28 AM, Alan Schmitt
>> > <alan.schm...@polytechnique.org> wrote:
>
>>> LGTM (with a tiny caveat that I can fix: the first line of the commit
>>> message should not end with a dot). Nicolas, can I push this?
>
> Sure. However, it would be nice to fix the two minor issues below.
>
>> From: Dmitri Makarov <dmaka...@alumni.stanford.edu>
>> Date: Wed, 9 Sep 2015 17:24:42 +0200
>> Subject: [PATCH] org-mac-link.el: Handle links to/from Adobe Acrobat
>>
>> * contrib/lisp/org-mac-link.el: Add new link type "acrobat" to grab
>> links to documents open in Adobe Acrobat application.
>
> You need to mention new functions and variables in the commit message.
>
>> +(defun as-get-acrobat-page-link ()
>
> Wrong namespace. It should be prefixed with "org-mac-".
>
>
> Regards,
>
> --
> Nicolas Goaziou
From ada3e9afbcadb6020b8e4949b49afc1243f8278d Mon Sep 17 00:00:00 2001
From: Dmitri Makarov <dmaka...@alumni.stanford.edu>
Date: Wed, 9 Sep 2015 17:24:42 +0200
Subject: [PATCH] org-mac-link.el: Handle links to/from Adobe Acrobat
Add new link type "acrobat" to grab links to documents open in Adobe
Acrobat application.
* contrib/lisp/org-mac-link.el (org-mac-acrobat-open): Open Adobe
Acrobat document pointed to by a link.
* contrib/lisp/org-mac-link.el (org-mac-as-get-acrobat-page-link):
Invoke applescript to generate a link to an open and active Adobe
Acrobat document.
* contrib/lisp/org-mac-link.el (org-mac-acrobat-get-page,
org-mac-acrobat-insert-page): methods used when an Adobe Acrobat link
grab request is issued or a link is clicked in an org document.
* contrib/lisp/org-mac-link.el (org-mac-grab-Acrobat-app-p): predicate
that enables grabbing Adobe Acrobat links.
---
contrib/lisp/org-mac-link.el | 60 +++++++++++++++++++++++++++++++++++++++++++-
1 file changed, 59 insertions(+), 1 deletion(-)
diff --git a/contrib/lisp/org-mac-link.el b/contrib/lisp/org-mac-link.el
index 5e0f891..01556f7 100644
--- a/contrib/lisp/org-mac-link.el
+++ b/contrib/lisp/org-mac-link.el
@@ -169,6 +169,12 @@
:group 'org-mac-link
:type 'boolean)
+(defcustom org-mac-grab-Acrobat-app-p t
+ "Add menu option [A]crobat to grab page links from Acrobat.app."
+ :tag "Grab Acrobat.app page links"
+ :group 'org-mac-link
+ :type 'boolean)
+
(defgroup org-mac-flagged-mail nil
"Options foring linking to flagged Mail.app messages."
:tag "Org Mail.app"
@@ -211,7 +217,8 @@ When done, go grab the link, and insert it at point."
("v" "imperator" org-mac-vimperator-insert-frontmost-url
,org-mac-grab-Firefox+Vimperator-p)
("c" "hrome" org-mac-chrome-insert-frontmost-url
,org-mac-grab-Chrome-app-p)
("t" "ogether" org-mac-together-insert-selected
,org-mac-grab-Together-app-p)
- ("S" "kim" org-mac-skim-insert-page ,org-mac-grab-Skim-app-p)))
+ ("S" "kim" org-mac-skim-insert-page ,org-mac-grab-Skim-app-p)
+ ("A" "crobat" org-mac-acrobat-insert-page
,org-mac-grab-Acrobat-app-p)))
(menu-string (make-string 0 ?x))
input)
@@ -543,6 +550,57 @@ The links are of the form <link>::split::<name>."
(interactive)
(insert (org-mac-skim-get-page)))
+;; Handle links from Adobe Acrobat Pro.app
+;;
+;; Original code & idea by Christopher Suckling (org-mac-protocol)
+;;
+;; The URI format is path_to_pdf_file::page_number
+
+(org-add-link-type "acrobat" 'org-mac-acrobat-open)
+
+(defun org-mac-acrobat-open (uri)
+ "Visit page of pdf in Acrobat"
+ (let* ((page (when (string-match "::\\(.+\\)\\'" uri)
+ (match-string 1 uri)))
+ (document (substring uri 0 (match-beginning 0))))
+ (do-applescript
+ (concat
+ "tell application \"Adobe Acrobat Pro\"\n"
+ " activate\n"
+ " set theDoc to \"" document "\"\n"
+ " set thePage to " page "\n"
+ " open theDoc\n"
+ " tell PDF Window 1\n"
+ " goto page thePage\n"
+ " end tell\n"
+ "end tell"))))
+
+;; The applescript returns link in the format
+;; "adobe:path_to_pdf_file::page_number::split::document_title, p.page_label"
+
+(defun org-mac-as-get-acrobat-page-link ()
+ (do-applescript
+ (concat
+ "tell application \"Adobe Acrobat Pro\"\n"
+ " set theDoc to active doc\n"
+ " set theWindow to (PDF Window 1 of theDoc)\n"
+ " set thePath to (file alias of theDoc)\n"
+ " set theTitle to (name of theWindow)\n"
+ " set thePage to (page number of theWindow)\n"
+ " set theLabel to (label text of (page thePage of theWindow))\n"
+ "end tell\n"
+ "set theResult to \"acrobat:\" & thePath & \"::\" & thePage &
\"::split::\" & theTitle & \", p.\" & theLabel\n"
+ "return theResult as string\n")))
+
+(defun org-mac-acrobat-get-page ()
+ (interactive)
+ (message "Applescript: Getting Acrobat page link...")
+ (org-mac-paste-applescript-links (org-mac-as-get-acrobat-page-link)))
+
+(defun org-mac-acrobat-insert-page ()
+ (interactive)
+ (insert (org-mac-acrobat-get-page)))
+
;; Handle links from Microsoft Outlook.app
--
2.5.1
