Hello, Sebastian Miele <sebastian.mi...@gmail.com> writes:
> * testing/lisp/test-ob-emacs-lisp.el > (test-ob-emacs-lisp-dynamic-lexical-text, > test-ob-emacs-lisp-dynamic-lexical-expr, > ob-emacs-lisp/dynamic-lexical-execute, > ob-emacs-lisp/dynamic-lexical-edit): Add tests that check the > correct handling of the :lexical header argument when executing > source blocks and when creating editing buffers for source blocks. Thank you. <nitpick> However, your tests are very convoluted. It is better than no test, but if, unfortunately, one of them fail in some distant future, it may take more time understanding what happens in the test than actually fixing the bug. Would you mind rewriting them with simple macros like, e.g., `org-test-with-temp-text', and use as little helper functions as possible? IMO, code repetition in tests is not a problem. </nitpick> Regards, -- Nicolas Goaziou
