> If have better solution, I totally agree with that. In the current state, your patch will be pretty much useless for users without technical background.
url-retrieve-synchronously + save-buffer should be a better default. It will be available for all users. Ideally, there should be several customisation options. Something like: - url-retrieve-synchronously - curl - wget - monolith Also, it would be great if you provide some description about each customisation in the docstring. For example, a link to github page of monolith and a brief description how it is different from other url retrieval methods should be useful for general user. Best, Ihor stardiviner <numbch...@gmail.com> writes: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > > Ihor Radchenko <yanta...@gmail.com> writes: > >>> This looks helpful, but I think this should be an add-on rather than >>> integrated into the org-attach. I'm glad to learn about monolith, but >>> far fewer users are likely to have it installed than have wget or curl >>> installed. You might also want to check out org-board, which has similar >>> functionality: >> >> It does not mean that attaching URL directly is not worth including into >> org. This sounds pretty common use case, especially considering the number >> of packages providing similar feature. You mentioned org-board, but >> there is also org-download and org-web-tools. > > That's right, this phenomenon represents an obviously situation, Org Mode > should > have this functionality. > >> >> I agree that monolith is completely uncommon tool and I would not expect >> the majority of users to have it installed, but the same functionality >> utilising built-in url.el (as a default) should be acceptable. > > If have better solution, I totally agree with that. > >> >> Best, >> Ihor >> >> >> Matthew Lundin <m...@imapmail.org> writes: >> >>> stardiviner <numbch...@gmail.com> writes: >>> >>>> I attached the patch. >>>> >>>> I think this feature will be helpful for use who archive web page data >>>> usually >>>> like me. To be more portable, I also added an defcustom option for other >>>> external command. And use an if condition to detect whether external >>>> command >>>> available, else warning user. >>> >>> This looks helpful, but I think this should be an add-on rather than >>> integrated into the org-attach. I'm glad to learn about monolith, but >>> far fewer users are likely to have it installed than have wget or curl >>> installed. You might also want to check out org-board, which has similar >>> functionality: >>> >>> https://github.com/scallywag/org-board >>> >>> Best, >>> >>> Matt >>> > > > - -- > [ stardiviner ] > I try to make every word tell the meaning that I want to express. > > Blog: https://stardiviner.github.io/ > IRC(freenode): stardiviner, Matrix: stardiviner > GPG: F09F650D7D674819892591401B5DF1C95AE89AC3 > > -----BEGIN PGP SIGNATURE----- > > iQFIBAEBCAAyFiEE8J9lDX1nSBmJJZFAG13xyVromsMFAl7PXKoUHG51bWJjaGls > ZEBnbWFpbC5jb20ACgkQG13xyVromsOiMQf9EY7ES42hWxdjgFqiN0UqPGssRd+l > fcvhb+yiT5/71TYA8YbQOF0Pa2SpUBgGUw+hcHUd9aDXxAP+4ucmP4bZ/vx29UTN > T7YpOvuc5ZkafiN5bWghij1dLYhfi2CMDGGduU9rvjSleaRMhoX12wo8OM2qBHDm > 2bqWHrZsGVPsNlAK3ymN3PdmwOtxktRVUxWZOug3ZF6LYnEHWRp/rb6lvS2BF3Ej > qNazerYVcpfDsOiCWTSrjos2gnITT2pSlnxmrQFO69Pvex+T2dEJL7raNyuXi3Qd > jn5uayrnHn4ZeUwSfmAQiqvq2TsFZ5zvtH0nKM+4tp/6gSgEuTw9gYaoBQ== > =qrFy > -----END PGP SIGNATURE----- > -- Ihor Radchenko, PhD, Center for Advancing Materials Performance from the Nanoscale (CAMP-nano) State Key Laboratory for Mechanical Behavior of Materials, Xi'an Jiaotong University, Xi'an, China Email: yanta...@gmail.com, ihor_radche...@alumni.sutd.edu.sg
