-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256
Matthew Lundin <m...@imapmail.org> writes: > Ihor Radchenko <yanta...@gmail.com> writes: > >> It does not mean that attaching URL directly is not worth including >> into org. This sounds pretty common use case, especially considering >> the number of packages providing similar feature. You mentioned >> org-board, but there is also org-download and org-web-tools. > > My uneasiness has more to do with the specificity of the dependence on > monolith and the way that is hard-coded into the patch. When it comes to > patches, I think priority should go to those that are configurable, > accessible, and useful for everyone as opposed to those that have > hard-coded work-flows or highly-specific user configurations. I don't think it's hardcoded, As I said in my first email, It's an `defcustom', isn't it? User totally can change that. And I used `executable-find', the value will be `nil' when monolith is not available. And I don't have ability to archive same functionality with wget or curl. And as I said before, PATCH welcome. > >> I agree that monolith is completely uncommon tool and I would not expect >> the majority of users to have it installed, but the same functionality >> utilising built-in url.el (as a default) should be acceptable. > > The question is: which functionality? A simple downloading tool or a > full archival tool? Achieving similar functionality to org-board or > monolith would a big task, since they aim to download an archival > version of a webpage (including all resources). In addition, with > archiving you also quickly run into the complexity of versioning based > on time archived. There's also the challenge of mapping the downloaded > files to metadata (specifically the original url). Org-board currently > handles both of these very well. If you mean adding a timestamp and original URL, I don't think its our argument point, because user totally can do it manually, or automatic this task in some kind of way. WDYT? > > I suppose there would be a few options depending on what the aims are: > > 1. At the simple end, include little more than than a quick and dirty > way of downloading a single resource (html, pdf, jpeg) using url.el > or wget (or optionally, monolith) and putting that in the attachment > folder. Those who want full archiving of all resources could use > other tools like org-board or org-web-tools. the [u] url downloading method already did the simple task. > > 2. At the (much) more complex end, it would be to code out a robust > archiving solution on top of url.el or wget. As I said, PATCH welcome, I admired many times I don't have ability to build a complex archive functionality on url.el or wget or curl. Isn't Org Mode build up from small things? Can just become a big tool at once? > > 3. Another, possibly simpler option... Add a command to the dispatcher > that allows the user to invoke a custom function that is called with > the attachment directory as the default-directory. This would enable > more end-user flexibility, such as the ability to use > wkhtmtoimage/wkhtmltopdf, monolith, phantom.js, archive.is, etc. > This is leaved to `defcustom' option. I will improve the download function to have enough elasticity. - -- [ stardiviner ] I try to make every word tell the meaning that I want to express. Blog: https://stardiviner.github.io/ IRC(freenode): stardiviner, Matrix: stardiviner GPG: F09F650D7D674819892591401B5DF1C95AE89AC3 -----BEGIN PGP SIGNATURE----- iQFIBAEBCAAyFiEE8J9lDX1nSBmJJZFAG13xyVromsMFAl7QbYMUHG51bWJjaGls ZEBnbWFpbC5jb20ACgkQG13xyVromsOFvAgAjTPtt5ZikNZnkp1gfuEGunVzblk6 D6O+qgZAamT0EpR2nwK9U+x470KZAhXiLURkVb0l9/6uvA6MQZtj+umX/Qer/6bw vB4RICWenFKyyBMy9U1pZ9WzTNw2ZNfeaEiJ0XlgXx9ZPGjBgcLi/7FSM4NybV4O qbGwHbp4AzZ4mJOrMchNwlQfDYpg381xDewnHeuwtkVeBc34HpuFEGYKdmtOJ16S mnL/5LrbI7MahlIZuiqyAzeyU3DkSvFOC/ovvch9YlAk1SeK/BslUcaGrwl/Il70 XG/28XaAvVW2OYrO9vOmwpdoguQqARhKeMuof6p85waf1OF8itd97P95Lw== =V/fu -----END PGP SIGNATURE-----