TEC writes:
> TEC <[email protected]> writes:
>
> Sorry about that, here's an actual revision.
Thanks, this series is a good improvement as far as I can tell. And
thank you Jens for all of the careful reviews.
I've applied this (a8df7670c) with two minor changes (shown in the diff
at end): s/with with/with/ in a docstring and move an element to its own
line to avoid the warning from lisp-mode's lisp--match-hidden-arg.
This thread has gone on long enough that I'll avoid requesting changes
for convention/style nits, but some things to keep in mind for future
patches:
* Your changes replace several `and's with `when's as well as a
one-armed if. The previous code is following the style/preference
of using `and' in cases where the return value is of interest,
leaving `when' for side effects. As mentioned in the message below
(just the first example I found when searching the list), it's
definitely a matter of taste and not a hard rule, but please try to
stick with that convention.
https://orgmode.org/list/[email protected]/
* Please avoid adding blank lines within function definitions.
* Please follow the project's convention of capitalizing the first
word after "<file/area>: " in the commit message subject.
Also, it'd be good for this to be accompanied by a NEWS entry. I'd
appreciated if that were sent in a separate thread, though. For some
reason I haven't debugged, my usual MUA can't load this thread.
Thanks again.
diff --git a/lisp/ox-html.el b/lisp/ox-html.el
index bd2ca1753..11757bb35 100644
--- a/lisp/ox-html.el
+++ b/lisp/ox-html.el
@@ -1431,8 +1431,8 @@ (defcustom org-html-meta-tags #'org-html-meta-tags-default
Can be a list where each item is a list of arguments to be passed
to `org-html--build-meta-entry'. Any nil items are ignored.
-Also accept a function which gives such a list when called with with
-a single argument (INFO, a communication plist)."
+Also accept a function which gives such a list when called with a
+single argument (INFO, a communication plist)."
:group 'org-export-html
:package-version '(Org . "9.5")
:type '(choice
@@ -1937,7 +1937,8 @@ (defun org-html--build-meta-info (info)
(lambda (args) (apply #'org-html--build-meta-entry args))
(delq nil (if (functionp org-html-meta-tags)
(funcall org-html-meta-tags info)
- org-html-meta-tags)) ""))))
+ org-html-meta-tags))
+ ""))))
(defun org-html--build-head (info)
"Return information for the <head>..</head> of the HTML output.
