Max Nikulin <maniku...@gmail.com> writes: > On 05/10/2021 23:32, Ihor Radchenko wrote: >> Max Nikulin writes: >> I tried come up with the reason why org-no-popup was used in the >> initial >> implementation. I think, the reason is avoiding situation like what you >> may see after running >> (let ((pop-up-frames t)) (funcall-interactively #'org-goto)) >> So, removing the macro completely is not a good idea. >> I have updated the patch that should work without dropping the >> macro. >> See the attached. > > Thank you, Ihor. > > Your updated patch works in default configuration (-Q). I am not > familiar with knobs of `display-buffer' function so I have no idea if > someone may complain that such variant overrides his setup or works > incorrectly with his preferences.
Please note the documentation of variable `pop-up-windows'. This variable is provided mainly for backward compatibility and should not be used in new code. The same holds for `pop-up-frames'. The drop of the macro looks like a good idea to me. Can someone please describe the price for dropping macro `org-no-popups'? @Ihor I do not understand what "situation" you mean.