Marco Wahl <marcowahls...@gmail.com> writes: > Since org-goto in main is still broken I'll commit the fix for org-goto > which kicks out the use of the macro org-no-popups (but not the macro > itself since it's used elsewhere AFAICS.) > > Max, Ihor! If you see the necessity of refinement please keep going!
I am inclined to think that org-no-popups may still be useful to suppress pop-up-frames. However, no so much for pop-up-windows. Note that I introduced pop-up-windows let-binding in org-no-popups in place of overriding display-buffer-alist. However, I did not fully understand pop-up-windows does and the current let-binding actually changes pop-up-windows value to nil (t is the Emacs default). I think we can simply remove pop-up-windows binding from org-no-popups. Feel free to commit this change. I am currently working on org-element-cache and do not spend much time on other patches. > BTW I think the name *Org Help* for the UI buffer could be better. Do you have better ideas? Maybe something like *Org-goto Help*? If we want to change it, we may want to do it now, before users actually use *Org Help* name i.e. in display-buffer-alist. display-buffer-alist did not affect *Org Help* before 399481bad, so we have low odds to break anybody's config yet. Best, Ihor