On 19 Dec 2021, Ihor Radchenko wrote:
Karl Fogel <kfo...@red-bean.com> writes:
Should we just remove `org-truely-invisible-p'? Or at least
correct the spelling of its name ("truely" should be "truly")?
I feel slightly reluctant about removal. If nothing, this
function can
be a reminder about visible-mode and keeping it has little
downside.
Though if others think that removing would be better, I would
also be
fine with it.
Renaming sounds reasonable. Just need to define obsolete alias
for the
old name in org-compat.el.
Could you prepare a patch? Having a patch may encourage more
feedback.
Sure; please see attached.
Best regards,
-Karl
>From bb229b4f8f78ae52962d7bc90c8b1d4993af8263 Mon Sep 17 00:00:00 2001
From: Karl Fogel <kfo...@red-bean.com>
Date: Thu, 31 Mar 2022 19:02:38 -0500
Subject: [PATCH] Mark function obsolete & fix spelling of its name
* lisp/org-macs.el (org-truely-invisible-p): Move to...
* lisp/org-compat.el (org-truly-invisible-p): ...here, and add...
(org-truely-invisible-p): ...this compatibility alias.
There are no callers of this function in Org Mode, nor in current
Emacs (on the 'master and 'emacs-28' branches at least). We discussed
whether to remove it entirely, and for now seem to have tentatively
decided not to remove it. See this thread for more details:
From: Ihor Radchenko
Subject: Re: Removing obsolete function `org-truely-invisible-p'.
To: Karl Fogel
Cc: Org Mode
Date: Sun, 19 Dec 2021 17:14:32 +0800
Message-ID: <87h7b5rm6f.fsf@localhost>
---
lisp/org-compat.el | 12 ++++++++++++
lisp/org-macs.el | 7 -------
2 files changed, 12 insertions(+), 7 deletions(-)
diff --git lisp/org-compat.el lisp/org-compat.el
index 38d330de6..43d44211e 100644
--- lisp/org-compat.el
+++ lisp/org-compat.el
@@ -402,6 +402,18 @@ See `org-link-parameters' for documentation on the other
parameters."
(make-obsolete 'org-add-link-type "use `org-link-set-parameters' instead."
"9.0")
;;;; Functions unused in Org core.
+
+;; Not used since commit 3baf246f4f (Nicolas Goaziou, 2016-04-28)
+(defun org-truly-invisible-p ()
+ "Check if point is at a character currently not visible.
+This version does not only check the character property, but also
+`visible-mode'."
+ (unless (bound-and-true-p visible-mode)
+ (org-invisible-p)))
+(define-obsolete-function-alias 'org-truely-invisible-p
+ 'org-truly-invisible-p "2022-03-31"
+ "Compatibility alias for legacy misspelling of `org-truly-invisible-p'.")
+
(defun org-table-recognize-table.el ()
"If there is a table.el table nearby, recognize it and move into it."
(when (org-at-table.el-p)
diff --git lisp/org-macs.el lisp/org-macs.el
index b39af9103..fb3c441e1 100644
--- lisp/org-macs.el
+++ lisp/org-macs.el
@@ -1151,13 +1151,6 @@ fontification."
(folding-only (memq value '(org-hide-block outline)))
(t value))))
-(defun org-truely-invisible-p ()
- "Check if point is at a character currently not visible.
-This version does not only check the character property, but also
-`visible-mode'."
- (unless (bound-and-true-p visible-mode)
- (org-invisible-p)))
-
(defun org-invisible-p2 ()
"Check if point is at a character currently not visible.
If the point is at EOL (and not at the beginning of a buffer too),
--
2.35.1
