Stefan Kangas <ste...@marxist.se> writes:

> The attached patch deletes some Emacs 24 compat code.  Org mode
> supports Emacs 26 or later, according to:
> https://orgmode.org/worg/org-maintenance.html#emacs-compatibility

Thanks! I have some comments.

>  ;;; Integration with and fixes for other packages
> diff --git a/lisp/org-fold-core.el b/lisp/org-fold-core.el
> index 88072852d..287686c01 100644
> --- a/lisp/org-fold-core.el
> +++ b/lisp/org-fold-core.el
> ...
> +(define-obsolete-function-alias 'org-fold-core--seq-partition 
> #'seq-partition "9.6")

> diff --git a/lisp/org-macs.el b/lisp/org-macs.el
> index da68d8b8f..07c177b0b 100644
> --- a/lisp/org-macs.el
> +++ b/lisp/org-macs.el
> @@ -70,18 +70,7 @@
> ...
> +(define-obsolete-function-alias 'org-without-partial-completion 'progn "9.6")
                                                                   ^#'progn

We usually put obsolete aliases into org-compat.el instead of sprinkling
them across the various .el files. Please move the
define-obsolete-function-alias statements to org-compat.

Best,
Ihor

Reply via email to