Matt <m...@excalamus.com> writes: > + (advice-add > + 'ob-shell-async-chunk-callback > + :filter-return > + (lambda (&rest r) > + (let ((result (car r))) > + (should (string= result "1\n2\n")) ; expect value > + result)) > + `((name . ,session-name))) > ... > + (catch 'too-long > + (while (string-match test-ob-shell/uuid-regex > (buffer-string)) > + (progn > + (sleep-for 0.01) > + (when (time-less-p wait-time (current-time)) > + (throw 'too-long (ert-fail "Took too long to get > result from callback"))))) > + t)))
Why not simply doing the `should' test when the `test-ob-shell/uuid-regex' match fails? Instead of returning `t'. Then, we will not need to use advise. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>