Matt <m...@excalamus.com> writes: > I've rewritten the test and updated the patch.
Thanks! > +(defun ob-shell-async-chunk-callback (string) > + "Filter applied to results before insertion. > +See `org-babel-comint-async-chunk-callback'." > + (replace-regexp-in-string (concat org-babel-sh-prompt "*") "" string)) Why not using `comint-prompt-regexp'? > +(ert-deftest test-ob-shell/session-async-valid-header-arg-values () > + "Test that session runs asynchronously for certain :async values." > + (let ((session-name "test-ob-shell/session-async-valid-header-arg-values") > + (kill-buffer-query-functions nil)) > + (cl-loop A simple `dolist' would do here. There is no reason to use `cl-loop'. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
