On 11/05/2024 23:58, Bruno Cardoso wrote:
On 2024-05-10, 18:09 +0700, Max Nikulin wrote:
<https://orgmode.org/worg/org-contribute.html#copyright>

I haven't yet. Will be glad to.

I hope, next patch revision will be the final one, so it can be notification that the procedure is completed. (Rebase to main HEAD might be necessary.)

The attached patch is now in this format.

+++ b/lisp/ol.el
@@ -1582,7 +1582,47 @@ PATH is a symbol name, as a string."
                          :follow #'org-link--open-help
                          :store #'org-link--store-help)

Sorry, but did you manually edit the patch?

git apply /tmp/org/0001-ol-support-for-shortdoc-link-type.patch
error: patch failed: lisp/ol.el:1582
error: lisp/ol.el: patch does not apply

and I see only 6 context lines, not 7.

+      (condition-case nil
+          (progn
+            (shortdoc-display-group group fn)
+            (and str (not fn) (search-forward str nil t)))
+        (error (message "Unknown shortdoc group or malformed link: `%s'"
+                        path)))))

If you wish to use `user-error' as in earlier revisions then you may use

        (error (user-error "Unknown shortdoc group or malformed link: `%s'"
                        path)))))

An alternative might be something like (feel free to ignore)

      (condition-case err
;; ...
        (error (signal 'user-error (cdr err)))) ; more )

to preserve message generated by `shortdoc-display-group'.

Reply via email to