Visuwesh <visuwe...@gmail.com> writes: >>> - (type (assoc (plist-get params :plot-type) >>> - org-plot/preset-plot-types)) >>> + (type (cdr (assoc (plist-get params :plot-type) >>> + org-plot/preset-plot-types))) >>> gnuplot-script) >> >> This may break the existing customization. >> Later in the function, TYPE is used as an argument for >> `org-plot/gnuplot-term-extra' and `org-plot/gnuplot-script-preamble'. >> Some users may have these two custom options adjusted to the older >> calling convention. >> >> To not break things, we should pass the full `assoc' to these functions. > > If you meant org-plot/gnuplot-script eventually calling these functions, > then I don't see how the above change will break things. Even in > org-plot/gnuplot-script, TYPE passed to both these user options are > > (let* ((type-name (plist-get params :plot-type)) > (type (cdr (assoc type-name org-plot/preset-plot-types)))) > > so there should be no harm done by the above change since TYPE is not an > argument taken by org-plot/gnuplot-script.
Agree. I accidentally moved away from the function that is actually being changed to org-plot/gnuplot-script that has nothing to do with TYPE binding you are changing in the patch. So, your code is ok here. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
