Jarmo Hurri <[email protected]> writes:

>> See a couple of suggestions in the attached diff.
>
> Incorporated.
>
> I included your error condition in case no output type is specified, but
> added a comment that it should never happen (default png is set if no
> other type is specified).

Thanks, and sorry for the late reply.


> Implemented now, except I used set-buffer-file-coding-system in the body
> of with-temp-file, which seems to accomplish the same thing (as let'ing
> coding-system-for-write).

Ok.

> -(defcustom org-ditaa-jar-option "-jar"
> -  "Option for the ditaa jar file.
> -Do not leave leading or trailing spaces in this string."
> -  :group 'org-babel
> -  :version "24.1"
> -  :type 'string)

You completely removed this defcustom.
Note that it is intentional and aims to address some reported bug. See
https://list.orgmode.org/orgmode/CABwL-UjJFXfH_2KsJSx9CJnvEMbwRy9AtFzADykKc5AEC=0...@mail.gmail.com/

The next step will be updating the docs on WORG.

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Reply via email to