Jarmo Hurri <[email protected]> writes: > So, overall I think that > > 1. this defcustom (org-ditaa-jar-option) does not fulfill its original > purpose because of the trailing space attached to it automatically
Agree. > 2. the original issue can be solved by using org-ditaa-jar-path; > furthermore, because of the trailing space issue, I suspect that > users who currently solve this problem in fact use org-ditaa-jar-path > instead of org-ditaa-jar-option Also agree. Note that org-ditaa-jar-path became user option in the same commit that introduced org-ditaa-jar-option. > Therefore, If I have undestood this correctly > > 1. removing the defcustom (org-ditaa-jar-option) would probably not break > any user code Not exactly. The difference between org-ditaa-jar-option and org-ditaa-jar-path is that the former is shell-escaped (after calling expand-file-name). It is unlikely, but there might be some difference when blindly replacing org-ditaa-jar-option with org-ditaa-jar-path. That said, the difference is not worth bothering too much about. We can indeed obsolete org-ditaa-jar-option and announce the obsoleting in ORG-NEWS. > 2. fixing org-ditaa-jar-option to fulfill its original purpose (by > removing the automatically attached trailing space) might break some > user code if org-ditaa-jar-option is in fact used by someone > 3. safest choice would probably be to make org-ditaa-jar-option an > obsolete variable and use it istead of "-jar" if defined. Agree. -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
