On 2026-02-07 06:22, Ihor Radchenko wrote: > I have some concerns about this one. > The old code uses > > `(["None" org-mouse-remove-match-and-spaces > :style radio > :selected ,(not (member (match-string group) keywords))]) > > while the new code refactors this to simply use "None", without > style/selected.
Since this menu is only available when clicking on existing priority cookies I don’t think it’s possible to see it with “None” selected. Also, in the absence of a cookie I think the assumed value is ‘org-priority-default’, so the default should be selected instead (and it is now, in the global context menu). I’ll hold off on attaching v2 in case you want to adjust this. > I think using org-priority-show is the most reasonable in terms of > historic behavior. Yeah you’re right, otherwise the command doesn’t make much sense (why would you need a command to show the priority when it’s already shown?). I switched to this in v2 and changed the menu text to “Show Weighted Priority”. > Maybe those messages can be simply removed. > I dug git history, and it looks like org-mouse-cmd was never there to > start with. org-mouse-cmd was introduced to replace _cmd, which was > removed in 79605a900 that moved `org-with-remote-undo' to use > `org-with-gensyms' that hides explicit let-binding inside macro. Ah fun, thanks for pointing out 79605a900. I removed the variable and messages in v2. Best, -- Jacob S. Gordon [email protected] Please don’t send me HTML emails or MS Office/Apple iWork documents. https://useplaintext.email/#etiquette https://www.fsf.org/campaigns/opendocument
