Peter Tittmann <[email protected]> writes: > Thanks for the pointer. I've read through org-pending.el and your Aug 2024 > review, and looked at the ob-core changes. > > To make sure I'm oriented correctly — it looks like the review of > org-pending.el itself has several open items (keymap inheritance, > customizable fringe bitmaps, the overlay cloning question, a couple of minor > cleanups), and the babel integration layer is unreviewed. The branch also > needs rebasing onto current HEAD.
Right. > I can start by: > 1. Rebasing the branch and resolving conflicts > 2. Addressing the straightforward review items (keymap inheritance, redundant > cl-flet, substitute-command-keys, customizable bitmaps) > 3. Testing the async path with emacs-jupyter specifically — that's where I > hit the original bug You may skip (2). You will need to read through the code anyway, and you will very likely find a couple of things you can improve along the way while testing the library yourself. Once you have a good idea about the code, we can go back to the code review. > The overlay cloning design question and the org-pending-user-cancel signaling > probably need Bruno's input. Bruno — are you still interested in > collaborating on this? Happy to take on the mechanical work if that frees you > up for the design questions. It would be ideal to get an update from Bruno. Also, he said that he has some plans about changes in the babel part. It would be nice to share more details about those. In the worst case we can proceed as is, with the goal to get emacs-jupyter support - having an example user will make things easier as we can test real-world scenarios; not just toy examples as in the library header. -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
