Morgan Smith <[email protected]> writes:

> I spent absolutely way too long on this but I think I did it.  Please
> let me know what you think

Thanks!
Looks reasonable in general.
I think we also need to update Package-Requires.

Also, for some context, I have been considering to reuse an existing
development solutions. For example, see 
https://github.com/emacs-eldev/eldev/discussions/101
That did not work though, although it is very tempting to not have to
manage everything via makefiles and instead rely on an existing solution.

> Is the a way to conditionally include compat so newer Emacs are not bogged
> down?

Could you elaborate?
We can simply check if something like compat-31 is available, but I am
not sure what the problem is.

> If the compat team is listening, org currently defines compatibility
> wrappers around the following items and it would be nice if they got
> added to compat (no pressure, just thought I'd ask):
>
> display-buffer-full-frame
> buffer-text-pixel-size
> with-undo-amalgamate
> time-convert
> with-connection-local-variables

We can ask Daniel.

> @@ -158,6 +158,10 @@ *** Using Org's Git repository
>  (add-to-list 'load-path "~/src/org-mode/lisp")
>  #+end_src
>  
> +You must also manually install =compat= library required by Org mode.
> +Using built-in =package.el=, you can run =M-x package-install <RET>
> +compat <RET>=.

I am wondering if we can simply switch to package-vc in the instructions.

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Reply via email to