Ihor Radchenko <[email protected]> writes: >> -(defconst org-dependencies '() >> +(defconst org-dependencies '((compat . (31))) >> "An alist of dependencies of org. >> Each item is of the form (PACKAGE . MINIMUM-VERSION).") > > This one is awkward, as it needs to be kept in sync with main package > requirements. > May we use `lm-package-requires' to ingest the requirements from org.el > headers? > > I also tested the patch and ran into two issues: > > 1. emacs-28 has issues with elpa signature > ... > ... > We may or may not address this particular problem - Emacs 31 release is > within reach, so Emacs 28 support will be dropped sooner rather than later.
(Emacs 31 is this month) > 2. make repro does not work even after make uppkg EMACS=emacs-29 > > make repro EMACS=emacs-29 will run make cleanall, so it fails all the time. > Maybe we should run make uppkg as a part of make repro, but that > will download things automatically, so maybe we should do it somehow > differently. For example, make repro may skip cleanpkg. > > Otherwise, the patch looks good. A gentle ping. It has been 2 months. -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
