Karthik Chikmagalur <[email protected]> writes:
>> I think I reviewed everything except ox-html now.
>> I pushed what I got to feature/org-latex-preview branch on savannah.
>> There were a number of cleanups, removing small typos, and what appears
>> to be errors during rebases. The current main is merged into the feature
>> branch, so everything should be up-to-date.
>
> Does this mean I should stop updating
> https://github.com/karthink/org-mode/tree/org-latex-preview and work on
> feature/org-latex-preview on Savannah instead? I don't have push
> privileges for the Org mode repo on Savannah.
What I did is a merge commit + a couple of fixes on top of your existing
branch. You can start from that point, setting upstream to savannah.
Alternatively, I can give you push access.
>> ox-html is problematic though. It will require more careful review on my
>> side.
>
> Except for the LaTeX images HTML export options, there should be no
> changes to ox-html. Is there something you want me to look at?
There are a couple of notes I have to look into:
1. There are still some mentions of inlining images in the ORG-NEWS
2. :alt handling on the branch likely has a regression vs main
#+begin_src emacs-lisp
(list :src source
- :alt (if (string-match-p
- (concat "^" org-preview-latex-image-directory) source)
- (org-html-encode-plain-text
- (org-find-text-property-in-string 'org-latex-src source))
- (file-name-nondirectory source)))
+ :alt (file-name-nondirectory source))
#+end_src
3. Several tests are failing
4. ox-html changes are vast and seemingly introduce a number of
regression. At least, I saw some features removed on the branch
compared to main but no alternative version is implemented on the
branch. Handing org-html--unlabel-latex-environment is one of them,
but I saw more yesterday and concluded that more careful review is
needed to not miss more.
I will have limited free time until next weekend, so I will not be able
to work on the review actively in the coming days.
--
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
