>From bea0daf422e9ab8f27addb412aa03456c89d5844 Mon Sep 17 00:00:00 2001
From: Ilya Shlyakhter <ilya_...@alum.mit.edu>
Date: Fri, 7 Mar 2014 01:09:13 -0500
Subject: [PATCH] Properties: Fix property-getting with inheritance

* lisp/org.el (org-entry-get-with-inheritance): Temporarily clear
org-file-properties, org-global-properties and org-global-properties-fixed
before calling org-entry-get on entries up the hierarchy from the queried entry.

Problem was that when org-entry-get-with-inheritance went up the hierarchy of
entries from a given entry, checking whether the property has been set in any of
the entries, it was calling org-entry-get, which always looks at file-scope and
global-scope properties.  So if our property was set file-wide or system-wide,
and somewhere up the hierarchy there was an entry which set some properties 
_other_
than the one we're looking up but did not set ours, org-entry-get would fill in
the global property value and report that our property was in fact set in that
entry.  The search would stop, and if the property was actually set further up
the hierarchy (which should override file-wide or system-wide settings), we
would never get to that up-the-hierarchy setting.

Illustration of fixed problem:

#+PROPERTY: myprop aaa
* headline A
        :PROPERTIES:
        :myprop: bbb
        :END:
*** headline B
                :PROPERTIES:
                :otherprop:       ccc
                :END:

    #+BEGIN_SRC emacs-lisp
    (message (org-entry-get-with-inheritance "myprop"))
    #+END_SRC

    #+RESULTS:
    : aaa

                Result should be bbb, which it is after the fix.
---
 lisp/org.el | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/lisp/org.el b/lisp/org.el
index 6f4b853..cd2a1c6 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -15548,14 +15548,15 @@ However, if LITERAL-NIL is set, return the string 
value \"nil\" instead."
       (save-restriction
        (widen)
        (catch 'ex
-         (while t
-           (when (setq tmp (org-entry-get nil property nil 'literal-nil))
-             (or (ignore-errors (org-back-to-heading t))
-                 (goto-char (point-min)))
-             (move-marker org-entry-property-inherited-from (point))
-             (throw 'ex tmp))
-           (or (ignore-errors (org-up-heading-safe))
-               (throw 'ex nil))))))
+         (let (org-file-properties org-global-properties 
org-global-properties-fixed)
+           (while t
+             (when (setq tmp (org-entry-get nil property nil 'literal-nil))
+               (or (ignore-errors (org-back-to-heading t))
+                   (goto-char (point-min)))
+               (move-marker org-entry-property-inherited-from (point))
+               (throw 'ex tmp))
+             (or (ignore-errors (org-up-heading-safe))
+                 (throw 'ex nil)))))))
     (setq tmp (or tmp
                  (cdr (assoc property org-file-properties))
                  (cdr (assoc property org-global-properties))
-- 
1.8.4

Reply via email to