Hi Aaron,

thanks for the patch.

Aaron Ecay <aarone...@gmail.com> writes:

> #+name: one
> #+begin_src R :results file graphics :file png
>   ...
> #+end_src

What happens when there is :file png with no #+name line?

> The benefit comes from the reduced duplication of information in the
> file.  It also becomes possible to use the usual property inheritance
> mechanisms (via #+PROPERTY lines or :PROPERTY: drawers) to specify
> result file types for multiple source blocks at once.
>
> This patch also introduces the :output-dir property, which can be used
> to redirect all the output from blocks in a (file/subtree) to a
> subdirectory.

Does :output-dir accept absolute or relative paths?  I'm asking
because you speak of "subdirectory", but both should be accepted
IMHO.

> The patch treats any :file args containing a period as before, so
> backwards compatibility with old files should in most cases be
> maintained.

Maybe there are cases where the :file value does not take an extension
but the user still want to write the output to this file?  How would
your patch handle this?

> If this patch looks good, I can provide tests and documentation.

Looks useful to me, but ":file png" looks wrong, with too much
implicit.  We should find something less confusing.

Thanks,

-- 
 Bastien

Reply via email to