Estop_latch has BUG in watchdog pin.
Here is PATCH to solve problem.



2010/11/23 Slavko Kocjancic <[email protected]>

>  Hello...
>
> Long time ago I already post problem with estop latch and in new version
> (git) stil isn't corrected.
>
> The problematic is watchdog. It should togle only when ok_out is true but
> does togle all the time.
> The change is needed in line 25 of estop_latch.comp
>
> from
>  watchdog = !watchdog;
> to
>  if ( ok_out ) {watchdog = !watchdog;}
>
> At least with that change the operation is correct.
>
> Slavko
>
>
>
> ------------------------------------------------------------------------------
> Increase Visibility of Your 3D Game App & Earn a Chance To Win $500!
> Tap into the largest installed PC base & get more eyes on your game by
> optimizing for Intel(R) Graphics Technology. Get started today with the
> Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs.
> http://p.sf.net/sfu/intelisp-dev2dev
> _______________________________________________
> Emc-developers mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/emc-developers
>
>
From b90b71df955919b96b61fd3a29f469602009b9f3 Mon Sep 17 00:00:00 2001
From: slavko <sla...@emc2.(none)>
Date: Thu, 2 Dec 2010 11:03:04 +0100
Subject: [PATCH] BUG in estop latch. The watchdog should toggle only if latch has ok_out

---
 src/hal/components/estop_latch.comp |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/hal/components/estop_latch.comp b/src/hal/components/estop_latch.comp
index 2a1e0dd..9cf84a6 100644
--- a/src/hal/components/estop_latch.comp
+++ b/src/hal/components/estop_latch.comp
@@ -22,7 +22,7 @@ FUNCTION(_) {
 	    fault_out = 0;
 	}
 	/* toggle watchdog */
-	watchdog = !watchdog;
+	if ( ok_out ) {watchdog = !watchdog;}
     } else {
 	/* fault condition exists, trip */
 	ok_out = 0;
-- 
1.5.4.3

------------------------------------------------------------------------------
Increase Visibility of Your 3D Game App & Earn a Chance To Win $500!
Tap into the largest installed PC base & get more eyes on your game by
optimizing for Intel(R) Graphics Technology. Get started today with the
Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs.
http://p.sf.net/sfu/intelisp-dev2dev
_______________________________________________
Emc-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/emc-developers

Reply via email to