On Thu, Apr 28, 2011 at 09:26:49PM +0100, andy pugh wrote: > > It would be convenient if you could teach your mailer to attach these as > > text/plain or text/x-patch. > > I can try not using Gmail.
Well, the trouble on my end is not *too* bad, just a few extra keypresses. > > The implementation I'd imagined involved mesa_7i65 and other bspi > > drivers defining *NO* hal functions. Instead, they would register > > function pointers with the hostmot2 driver to call at the appropriate > > times (when processing a read or preparing a write). This would > > require a modification to comp, which currently always rejects a > > component with no functions. > > Does it also need to allow function pointers in comp, which I > accidentally might have introduced and you took out again? I don't *think* so. The function pointers will be passed to the bits of hostmot2 written in C, so not something you'll need to declare with 'variable'. > > Avoid unnecessary whitespace changes. > > The hard part is working out what whitespace to put back in to fix it :-) > (I assume --whitespace, reset then git-am is the way to go.) When committing, consider using "git gui" to do it. It facilitates not committing unwanted changes in the first place, and I also like the way it makes me review my code one more time before committing it. "git gui" lets you go line-by-line, by line ranges, or by diff hunks, adding just what you want to be committed. Basically, it encourages you to review what you're commiting before you commit it, and gives you an easy way to not commit what you decide should be skipped (like changes that are just whitespace) or saved for a second commit (like changes that are logically separate but that you happened to write at about the same time). If you've already committed, then you can go back and do it with "git rebase -i", then do the same excluding of the changes you don't want with "git gui" in "amend last commit" mode. I won't try to talk you through all the details of "git gui" and "git rebsae -i", but just remember that those tools are out there, and maybe practice with some changes you don't care about to get accustomed to them. Jeff ------------------------------------------------------------------------------ WhatsUp Gold - Download Free Network Management Software The most intuitive, comprehensive, and cost-effective network management toolset available today. Delivers lowest initial acquisition cost and overall TCO of any competing solution. http://p.sf.net/sfu/whatsupgold-sd _______________________________________________ Emc-developers mailing list Emc-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/emc-developers
