Several of the listed files are from me. I can't push anything to the LinuxCNC repository, but I'm willing to clean up my files and commit them. I have a github clone of the LinuxCNC repository where I can push changes to the ubc-3 branch and send a pull request, or would you prefer a different work-flow?
Alternately, I can push to my MachineKit branch (currently based off ubc-2) and changes can be pulled into ubc-3. Let me know...details in-line. On 9/11/2013 2:34 PM, Jeff Epler wrote: > I inspected the list of files added in the ub3 branch for potential > problems. Unfortunately, I have found some. The most serious > categories are: Files with an "All Rights Reserved" copyright notice, > files with no copyright or license declaration, and files not "in the > preferred form for modification" (minified js files). There are also > some minor issues I noticed. > > In my view, being aware of these "All Rights Reserved", no-license, and > preferred-form problems, we MUST resolve them before merging the branch. > > I think it would be very fortunate if we can ensure that all code added > in this branch was "GPLv2+" but I would personally not let a GPLv2-only > file stand in the way of its adoption. Thanks for looking through the files! Several of them are mine, and I just missed adding the license header. I'm willing to license the files GPLv2+ or whatever works best for the project, including public domain or even something like MIT/BSD. > = configs/ARM/BeagleBone/BeBoPr-Bridge/BB-LCNC-BEBOPRBR-00A0.dts > = configs/ARM/BeagleBone/K9/Device_Tree_Overlays/BB-BLACK-LCNC-K9-00A0.dts > = configs/ARM/BeagleBone/K9/Shapeoko/temp/LCNC-BBB-K9S-00A0.dts > > Do not contain license declaration. Are these generated files or are > they all hand-written? They are written, not generated. I'll add license headers. > = configs/ARM/BeagleBone/BeBoPr-Bridge/dtc.sh and other new sh files > > Does not contain license declaration. Some appear to be duplicated in > multiple > directories; use our facility configs/common so that build process copies to > each destination. Or put them in scripts/ if sensible. This is from me as well, I'll add a license header. I realize there is a fair amount of duplication of some files in the BeagleBone config directories. I'm still working out how to put things like python scripts and include files in common places that can be referenced in HAL files. I am willing and anxious to get rid of the duplication...I'm the one having to keep all the various files updated and synchronized! :) All help and suggestions are greatly appreciated! Particularly with how to put python based user-mode HAL components in a common location and still be able to load them from a HAL file! > = scripts/gen-rtapi.ini.sh.in.tmpl > = scripts/kernel-vers.sh > = scripts/pru_debug > > Does not contain license declaration scripts/pru_debug is mine... <snip> Thanks again for the review! -- Charles Steinkuehler [email protected]
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ How ServiceNow helps IT people transform IT departments: 1. Consolidate legacy IT systems to a single system of record for IT 2. Standardize and globalize service processes across IT 3. Implement zero-touch automation to replace manual, redundant tasks http://pubads.g.doubleclick.net/gampad/clk?id=51271111&iu=/4140/ostg.clktrk
_______________________________________________ Emc-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/emc-developers
