On 09/07/2016 04:49 PM, Jeff Epler wrote: > At least three things fall in the category "It is an error if ...": > > * The part program is invalid, and LinuxCNC rejects it with a message. > > * The part program is invalid, but LinuxCNC may not detect it. > Undesired motion (or other action) may ensue. This could reflect a > case that the developer knows she did not correctly define during the > design of the interpreter. > > * The part program is invalid, and a future version of LinuxCNC > is free to assign a different meaning to the part program in > a future release, with or without notice in the documentation. > > Some of the things listed as an error for G76 clearly fall into the > second two categories. > > Jeff
I'm not following the above well. Let's take the first item in the manual's G76 error list. http://linuxcnc.org/docs/2.7/html/gcode/g-code.html#gcode:g76 "... It is an error if: The active plane is not the ZX plane ..." Currently, the interp_convert.cc code contents for G76 doesn't seem to check for the active plane. In running g-code I can set any plane and G76 runs normally, (although the active g-codes box always switches to indicate G17 when the cycle starts). So, should the line about the active plane be removed from the G76 manual entry because it's not really an error. Or, am I missing something and interp_convert needs to be edited to add a check for the active plane? If so, what am I missing that makes this check necessary? The goal is to bring the source code, performance, and the documentation into agreement. I am also assuming that "It is an error if" means that if an error occurs, somewhere along the line an error message will be presented and running the code will be prevented, rather than implying "this is a mistake so don't do this". Either way could be valid, but I know what I usually prefer. At this point since G76 seems to function well enough in this regard, it would be best to remove this item from the manual. -- Kirk Wallace http://www.wallacecompany.com/machine_shop/ http://www.wallacecompany.com/E45/ ------------------------------------------------------------------------------ _______________________________________________ Emc-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/emc-developers
